Page MenuHomePhabricator

Edit notices box not displaying all the items or not displaying them well?
Open, MediumPublic1 Estimated Story Points

Description

Compare https://it.wikipedia.org/w/index.php?title=Carmine_Buschini&action=edit&redlink=1 and https://it.wikipedia.org/w/index.php?title=Carmine_Buschini&veaction=edit . The former has a few colored boxes with various info, and 2 boxes displaying the deletion and the protection logs. In VE, the colored boxes are partially there; the deletion logs are not available at all, while the protection log box only displays the first line, without the actual log entry. Most importantly though, I can't really read much there because the box starts flickering a lot if I scroll in any direction. This is in Safari, Air.

I believe the German community is interested in displaying a notice about pages that shouldn't be recreated because they had already been deleted in the past.

Event Timeline

Elitre created this task.Dec 13 2016, 8:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2016, 8:08 PM
Jdforrester-WMF triaged this task as Medium priority.Dec 13 2016, 8:24 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Can confirm, titleprotectedwarning isn't getting populated, and, it looks like recreate-moveddeleted-warn isn't being put up — is this a special case that doesn't declare itself to be an edit notice in MediaWiki?

Even worse in this case: https://it.wikipedia.org/w/index.php?title=Carmine_Buschini&action=edit&redlink=1 tells me, I'm not allowed to create that page (https://it.wikipedia.org/w/index.php?title=Carmine_Buschini&action=info confirms this), while VE let's me start editing (and probably will fail when I try to save).

Another example on enwiki - going to a page with editnotices (e.g. https://en.wikipedia.org/w/index.php?title=Abortion&action=edit) using the source editor works fine - if switching to VE the notices are lost, manually looking for them in the triangle button says no notices. (Firefox, monobook)

Isarra added a subscriber: Isarra.Mar 23 2017, 4:51 PM

The notices seem to only show up expanded when opening it initially, usually - otherwise they're always collapsed, and users are not likely to expand them to look at them. In the case of editnotices and the like, the whole point is for them to be seen and in many cases used, so hiding them away in a typically closed thing, which cannot be kept around while doing anything else on the page, is perhaps not the best approach.

The referenced Carmine_Buschini page now displays identically in action=edit and veaction=edit, because of a side-effect of @matmarex's recent ae8b0a1. The page isn't editable, so the #ca-edit element (the edit tab) isn't shown, so VE refuses to load.

...the "your skin isn't supported" message it leaves in the console is admittedly rather misleading in this case.

@Jdforrester-WMF: Should we be allowing veaction=edit to forcibly load VE in this case, with the associated edit notices, or is the current behavior correct?

The referenced Carmine_Buschini page now displays identically in action=edit and veaction=edit, because of a side-effect of @matmarex's recent ae8b0a1. The page isn't editable, so the #ca-edit element (the edit tab) isn't shown, so VE refuses to load.

...the "your skin isn't supported" message it leaves in the console is admittedly rather misleading in this case.

That's T162411: "Your skin is incompatible with VisualEditor" warning on protected pages.

@Jdforrester-WMF: Should we be allowing veaction=edit to forcibly load VE in this case, with the associated edit notices, or is the current behavior correct?

That's T53547: VisualEditor: Provide a "view VE" mode / disable editing for protected pages.

Because my account has +sysadmin, for me navigating from https://it.wikipedia.org/w/index.php?title=Carmine_Buschini read mode to "create" or going straight to https://it.wikipedia.org/w/index.php?title=Carmine_Buschini&veaction=edit I get:

The second edit notice is correct, but isn't populated for some reason.

(Ignore the warning background telling me I'm using high-powered account on a production wiki.)

If I switch to the old wikitext editor and back again I get an empty set of notices:

… which was just fixed in T162812: Edit intro is not shown when a user switches from wikitext editor to visualeditor.

Consequently, post-Thursday the only outstanding issue that isn't already in another task is the titleprotectedwarning edit notice getting populated?