JsonConfig needs Scribunto for extension-gate
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	thcipriani
	Dec 14 2016, 12:33 AM

Description

Earlier today, Scribunto was added as a dependency for JsonConfig (see rCICFfae709dce6b7: Added Scribunto to JsonConfig instead of Kartographer).

This works fine for the extension-unittests-generic jobs; however, it fails for the extension-gate jobs due to T125050: [Task] Add Scribunto to extension-gate in CI.

Should JsonConfig be removed from extension-gate (see @Paladox's patch: https://gerrit.wikimedia.org/r/#/c/327132/)? @hashar? thoughts/ideas/schemes?

Mentioned Here: rCICFfae709dce6b7: Added Scribunto to JsonConfig instead of Kartographer
T125050: [Task] Add Scribunto to extension-gate in CI

So the issue was in https://gerrit.wikimedia.org/r/#/c/326906/ So that has been worked around by skipping the tests.

We will want to split the tests in different parts and only run the one that we care about:. A basic drawing https://docs.google.com/drawings/d/1ebVAFqM80Me7HCiLV-JdAkNCh3unLCGsuNqRcgiGtEI/edit

Will want to explicitly scope it out, involves developers, get an RFC and build the necessary logic in MediaWiki + CI.

I am not sure what the task was about.

JsonConfig is in the gate since 2014 and Scribunto got added recently. I have confirmed that the tests are indeed run.