Citoid restbase endpoint not configured correctly in vagrant
Closed, DeclinedPublic0 Estimated Story Points
Actions

Description

Two separate issues:

A request to the end point doesn't work.

For instance, https://en.wikipedia.org/api/rest_v1/data/citation/mediawiki/http%3A%2F%2Fexample.com returns valid data.

However, on my machine (using vagrant)

http://dev.wiki.local.wmftest.net:8080/api/rest_v1/data/citation/mediawiki/http%3A%2F%2Fexample.com

returns

{"type":"https://mediawiki.org/wiki/HyperSwitch/errors/not_found#route","title":"Not found.","method":"get","uri":"/dev.wiki.local.wmftest.net/v1/data/citation/mediawiki/http%3A//example.com"}

This may be related to what happens when you use the GUI to generate the request:

If you select "mediawiki" from the drop down, and put "http://example.com" in the search field, and hit the "Try it out" button, it gives you the following request URL:

http://dev.wiki.local.wmftest.net:8080/dev.wiki.local.wmftest.net/v1/data/citation/mediawiki/http%3A%2F%2Fwww.example.com

Details

	Subject	Repo	Branch	Lines +/-
	RESTBase: Add the Citoid config	mediawiki/vagrant	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned In: T237819: Install VisualEditor and Citoid on Wikispore

Event Timeline

Mvolz created this task.Dec 14 2016, 5:16 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 14 2016, 5:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Mvolz added a parent task: T108646: Set-up Citoid behind RESTBase.Dec 14 2016, 5:27 PM

Mvolz moved this task from Backlog to Production on the Citoid board.Dec 15 2016, 9:34 AM

cc: @Pchelolo

Mvolz triaged this task as Medium priority.Dec 15 2016, 11:50 AM

I'll take this one. The config needs to be updated most likely.

Change 327518 had a related patch set uploaded (by Mobrovac):
RESTBase: Add the Citoid config

https://gerrit.wikimedia.org/r/327518

gerritbot added a project: Patch-For-Review.Dec 15 2016, 3:30 PM

Change 327518 merged by jenkins-bot:
RESTBase: Add the Citoid config

https://gerrit.wikimedia.org/r/327518

Should be fixed now. Resolving.

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Jan 14 2017, 3:34 AM

Jdforrester-WMF set the point value for this task to 0.

bd808 moved this task from Backlog to Done on the MediaWiki-Vagrant board.Jan 23 2017, 4:09 PM

This issue as originally reported is still ongoing - should I create a separate issue since it seems to be two different issues and it mutated halfway through?

I made a completely fresh install on vagrant on a different machine with a different operating system today (Debian 9 - Other OS was Ubuntu 14.04) and I still have the same issue, where citoid is configured incorrectly, and returns hyperswitch errors, which means that it does not work with Citoid extension in VE in vagrant.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 16 2017, 6:20 PM

@Mvolz do you get a 404 regardless of the input?

In T153214#3688585, @mobrovac wrote:

@Mvolz do you get a 404 regardless of the input?

No, some input works, i.e. http://dev.wiki.local.wmftest.net:8080/api/rest_v1/data/citation/mediawiki/www.example.com

Basically anything that's encoded is 404 not found though, i.e. http://dev.wiki.local.wmftest.net:8080/api/rest_v1/data/citation/mediawiki/10.1371%2Fjournal.pcbi.1002947

Hm, ok, If that's the case, that might be an issue with the Apache rewrite rule decoding the URI or some similar magic.

In T153214#3697263, @mobrovac wrote:

Hm, ok, If that's the case, that might be an issue with the Apache rewrite rule decoding the URI or some similar magic.

I think I might have been slightly misleading because I confused this with another task, but the config issue still exists as well (wrong URL).

So, I think this one actually *was* resolved, it was actually this one where only 1 of the issues was resolved: https://phabricator.wikimedia.org/T162468

So I think it actually think it could be entirely config.

I'm confused @Mvolz :) It is unlikely that the problem is in RESTBase's config if search parameters without a / work, but the ones with it don't. Or am I missing something?

Well, I agree a priori that it seems unusual. But the fix for this bug
before was a config change, and that fixed both problems :).

@Mvolz is this still an issue?

Mvolz moved this task from Done to Backlog on the MediaWiki-Vagrant board.Jun 25 2018, 2:44 PM

Mvolz edited projects, added Services; removed Services (done).

In T153214#4015515, @mobrovac wrote:

@Mvolz is this still an issue?

Just updated everything, and yup :)

In T153214#3699305, @Mvolz wrote:

Well, I agree a priori that it seems unusual. But the fix for this bug
before was a config change, and that fixed both problems :).

Which config change (or which type thereof) are you referring to?

In T153214#4312841, @mobrovac wrote:

In T153214#3699305, @Mvolz wrote:

Well, I agree a priori that it seems unusual. But the fix for this bug
before was a config change, and that fixed both problems :).

Which config change (or which type thereof) are you referring to?

I'm assuming https://gerrit.wikimedia.org/r/#/c/mediawiki/vagrant/+/327518/

But I made that comment ages ago so I'm not really sure.

In T153214#4407849, @Mvolz wrote:

In T153214#4312841, @mobrovac wrote:

In T153214#3699305, @Mvolz wrote:

Well, I agree a priori that it seems unusual. But the fix for this bug
before was a config change, and that fixed both problems :).

Which config change (or which type thereof) are you referring to?

I'm assuming https://gerrit.wikimedia.org/r/#/c/mediawiki/vagrant/+/327518/

But I made that comment ages ago so I'm not really sure.

I looks like that config change was pre-restbase so it's not really relevant anymore.

• mobrovac added a project: Platform Team Workboards (Doing).Dec 20 2018, 12:43 PM

In T153214#4407877, @Mvolz wrote:

In T153214#4407849, @Mvolz wrote:

In T153214#4312841, @mobrovac wrote:

In T153214#3699305, @Mvolz wrote:

Well, I agree a priori that it seems unusual. But the fix for this bug
before was a config change, and that fixed both problems :).

Which config change (or which type thereof) are you referring to?

I'm assuming https://gerrit.wikimedia.org/r/#/c/mediawiki/vagrant/+/327518/

But I made that comment ages ago so I'm not really sure.

I looks like that config change was pre-restbase so it's not really relevant anymore.

On further examination it looks like there's two instances running: http://localhost:1970/?doc seems to be running fine, but the extension is querying the restbase version, which is broken. I'm not sure whether we want to fix it to just use the working http://localhost:1970 one, or to take that one down and try to correct the restbase one, but the restbase one is what we're running in production so probably copying that behaviour is better.

In T153214#4980104, @Mvolz wrote:

On further examination it looks like there's two instances running: http://localhost:1970/?doc seems to be running fine, but the extension is querying the restbase version, which is broken. I'm not sure whether we want to fix it to just use the working http://localhost:1970 one, or to take that one down and try to correct the restbase one, but the restbase one is what we're running in production so probably copying that behaviour is better.

Agreed that going through RESTBase is better. We are now doing some major work on RESTBase, and once we are done we'll need to update the Vagrant config for it anyway, so we'll look into it then. In the meantime, it is safe to shortcut this and use Citoid directly (provided we place TODOs there so as not to forget :P)

• Pchelolo edited projects, added Platform Engineering (Needs Cleaning - Services Operations); removed Platform Team Legacy (Later), Services (later).Jul 17 2019, 4:56 PM

• WDoranWMF edited projects, added MediaWiki-extensions-ClickTracking; removed Platform Engineering (Needs Cleaning - Services Operations).Oct 30 2019, 6:56 PM

• WDoranWMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed MediaWiki-extensions-ClickTracking.

• WDoranWMF moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 31 2019, 8:54 PM

Mvolz mentioned this in T237819: Install VisualEditor and Citoid on Wikispore.Jan 10 2020, 11:02 AM

• AMooney edited projects, added Platform Engineering (Icebox); removed Platform Team Workboards (Clinic Duty Team).Mar 13 2020, 1:34 PM

matmarex added a project: Editing-team (Third-party).Feb 17 2021, 10:22 AM