drvstartid/drvendid missing from prop=deletedrevisions
Open, Needs TriagePublic

Description

The prop=deletedrevisions largely reflects the parameters and behaviors of prop=revisions. This is a great utility. However, it seems that white rvstartid and rvendid exist for prop=revisions, they have not been implemented for prop=deletedrevisions.

I'd expect drvstartid and drvendid to filter based on ar_rev_id -- not the auto-generated ar_id column.

Halfak created this task.Dec 14 2016, 7:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2016, 7:39 PM
Anomie added a subscriber: Anomie.Dec 15 2016, 9:49 PM

The difficulty here is that there's no appropriate index. You'd need to add an index on (ar_namespace, ar_title, ar_timestamp, ar_rev_id) to make it workable, or (ar_namespace, ar_title, ar_rev_id) and lose the sorting by timestamp when these parameters are used.

In the case of prop=revisions, we already have the necessary index in page_timestamp.

Do you have a use case in mind for this?

Halfak added a comment.EditedDec 15 2016, 11:18 PM

Yeah! So I use prop=revisions to look for reverted edits. In order to do that, I need to look at the edits before and after a specific rev_id.

Edits before: prop=revision&rvdir=older&rvlimit=15&rvprop=ids|sha1&rvstartid=<rev_id - 1>&pageids=<page_id>
Edits after: prop=revision&rvdir=newer&rvlimit=15&rvprop=ids|sha1&rvstartid=<rev_id + 1>&pageids=<page_id>