Page MenuHomePhabricator

Inserting a new citation in the new wikitext editor JS fatals with "Uncaught TypeError: Cannot read property 'getRange' of null" in TransactionBuilder#newFromDocumentInsertion
Closed, ResolvedPublic1 Estimated Story Points

Description

ve.dm.TransactionBuilder.js?5930e:124 Uncaught TypeError: Cannot read property 'getRange' of null
    at Object.ve.dm.TransactionBuilder.static.newFromDocumentInsertion (https://en.wikipedia.beta.wmflabs.org/w/extensions/VisualEditor/lib/ve/src/dm/ve.dm.TransactionBuilder.js?5930e:124:33)
    at VeDmMWReferenceModel.ve.dm.MWReferenceModel.updateInternalItem (https://en.wikipedia.beta.wmflabs.org/w/extensions/Cite/modules/ve-cite/ve.dm.MWReferenceModel.js?fa81e:151:35)
    at VeUiCiteFromIdInspector.ve.ui.CiteFromIdInspector.onPreviewSelectWidgetChoose (https://en.wikipedia.beta.wmflabs.org/w/extensions/Citoid/modules/ve.ui.CiteFromIdInspector.js?6049c:371:24)
    at VeUiCiteFromIdGroupWidget.oo.EventEmitter.emit (https://en.wikipedia.beta.wmflabs.org/w/resources/lib/oojs/oojs.jquery.js?d40c1:775:12)
    at VeUiCiteFromIdGroupWidget.ve.ui.CiteFromIdGroupWidget.onItemInsert (https://en.wikipedia.beta.wmflabs.org/w/extensions/Citoid/modules/ve.ui.CiteFromIdGroupWidget.js?7eb7a:40:7)
    at VeUiCiteFromIdGroupWidget.oo.EventEmitter.emit (https://en.wikipedia.beta.wmflabs.org/w/resources/lib/oojs/oojs.jquery.js?d40c1:775:12)
    at VeUiCiteFromIdReferenceWidget.oo.EventEmitter.emit (https://en.wikipedia.beta.wmflabs.org/w/resources/lib/oojs/oojs.jquery.js?d40c1:775:12)
    at VeUiCiteFromIdReferenceWidget.ve.ui.CiteFromIdReferenceWidget.onInsertButtonClick (https://en.wikipedia.beta.wmflabs.org/w/extensions/Citoid/modules/ve.ui.CiteFromIdReferenceWidget.js?a38a0:112:7)
    at OoUiButtonWidget.oo.EventEmitter.emit (https://en.wikipedia.beta.wmflabs.org/w/resources/lib/oojs/oojs.jquery.js?d40c1:775:12)
    at OoUiButtonWidget.OO.ui.mixin.ButtonElement.onClick (https://en.wikipedia.beta.wmflabs.org/w/resources/lib/oojs-ui/oojs-ui-core.js?336be:1920:13)ve.dm.TransactionBuilder.static.newFromDocumentInsertion @ ve.dm.TransactionBuilder.js?5930e:124ve.dm.MWReferenceModel.updateInternalItem @ ve.dm.MWReferenceModel.js?fa81e:151ve.ui.CiteFromIdInspector.onPreviewSelectWidgetChoose @ ve.ui.CiteFromIdInspector.js?6049c:371oo.EventEmitter.emit @ oojs.jquery.js?d40c1:775ve.ui.CiteFromIdGroupWidget.onItemInsert @ ve.ui.CiteFromIdGroupWidget.js?7eb7a:40oo.EventEmitter.emit @ oojs.jquery.js?d40c1:775oo.EventEmitter.emit @ oojs.jquery.js?d40c1:775ve.ui.CiteFromIdReferenceWidget.onInsertButtonClick @ ve.ui.CiteFromIdReferenceWidget.js?a38a0:112oo.EventEmitter.emit @ oojs.jquery.js?d40c1:775OO.ui.mixin.ButtonElement.onClick @ oojs-ui-core.js?336be:1920dispatch @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1u1uxh5:4670elemData.handle @ load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=1u1uxh5:4338
sandbox?veaction=editsource&debug=true:1 Mixed Content: The page at 'https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/sandbox?veaction=editsource&debug=true' was loaded over HTTPS, but requested an insecure image 'http://sentry-beta.wmflabs.org/api/4/store/?sentry_version=4&sentry_client=…3A%22en%22%7D%2C%22event_id%22%3A%2240a22545678646128883bc797980b7b8%22%7D'. This content should also be served over HTTPS.

Event Timeline

Change 327371 had a related patch set uploaded (by Esanders):
Use deep clone for empty convertFromSource

https://gerrit.wikimedia.org/r/327371

Change 327371 merged by jenkins-bot:
Use deep clone for empty convertFromSource

https://gerrit.wikimedia.org/r/327371

Change 327374 had a related patch set uploaded (by Jforrester):
Use deep clone for empty convertFromSource

https://gerrit.wikimedia.org/r/327374

Change 327375 had a related patch set uploaded (by Jforrester):
Use deep clone for empty convertFromSource

https://gerrit.wikimedia.org/r/327375

Change 327375 merged by jenkins-bot:
Use deep clone for empty convertFromSource

https://gerrit.wikimedia.org/r/327375

Change 327374 merged by jenkins-bot:
Use deep clone for empty convertFromSource

https://gerrit.wikimedia.org/r/327374