Page MenuHomePhabricator

SocialProfile missing api i18n messages
Closed, ResolvedPublic

Description

The extension is using old API message formats, these should be replaced with i18n messages with entries in en.json and qqq.json

See https://www.mediawiki.org/wiki/API:Localisation for more information. Looking at many other extensions will also provide working examples. Such as https://github.com/wikimedia/mediawiki-extensions-CodeReview/blob/master/api/ApiCodeDiff.php#L73-L95 along with https://github.com/wikimedia/mediawiki-extensions-CodeReview/blob/master/i18n/en.json#L192-L195 and https://github.com/wikimedia/mediawiki-extensions-CodeReview/blob/master/i18n/qqq.json#L218-L221

21:16:57 1) ApiDocumentationTest::testDocumentationExists with data set "Module socialprofile-delete-message with MiserMode=false, AllowCategorizedRecentChanges=false" ('socialprofile-delete-message', array(false, false))
21:16:57 Module description message apihelp-socialprofile-delete-message-description exists
21:16:57 Failed asserting that false is true.
21:16:57 
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:51
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:80
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:399
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/maintenance/doMaintenance.php:111
21:16:57 
21:16:57 2) ApiDocumentationTest::testDocumentationExists with data set "Module socialprofile-delete-message with MiserMode=true, AllowCategorizedRecentChanges=true" ('socialprofile-delete-message', array(true, true))
21:16:57 Module description message apihelp-socialprofile-delete-message-description exists
21:16:57 Failed asserting that false is true.
21:16:57 
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:51
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:80
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:399
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/maintenance/doMaintenance.php:111
21:16:57 
21:16:57 3) ApiDocumentationTest::testDocumentationExists with data set "Module socialprofile-send-message with MiserMode=false, AllowCategorizedRecentChanges=false" ('socialprofile-send-message', array(false, false))
21:16:57 Module description message apihelp-socialprofile-send-message-description exists
21:16:57 Failed asserting that false is true.
21:16:57 
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:51
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:80
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:399
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/maintenance/doMaintenance.php:111
21:16:57 
21:16:57 4) ApiDocumentationTest::testDocumentationExists with data set "Module socialprofile-send-message with MiserMode=true, AllowCategorizedRecentChanges=true" ('socialprofile-send-message', array(true, true))
21:16:57 Module description message apihelp-socialprofile-send-message-description exists
21:16:57 Failed asserting that false is true.
21:16:57 
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:51
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:80
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:399
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/maintenance/doMaintenance.php:111
21:16:57 
21:16:57 5) ApiDocumentationTest::testDocumentationExists with data set "Module socialprofile-request-response with MiserMode=false, AllowCategorizedRecentChanges=false" ('socialprofile-request-response', array(false, false))
21:16:57 Module description message apihelp-socialprofile-request-response-description exists
21:16:57 Failed asserting that false is true.
21:16:57 
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:51
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:80
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:399
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/maintenance/doMaintenance.php:111
21:16:57 
21:16:57 6) ApiDocumentationTest::testDocumentationExists with data set "Module socialprofile-request-response with MiserMode=true, AllowCategorizedRecentChanges=true" ('socialprofile-request-response', array(true, true))
21:16:57 Module description message apihelp-socialprofile-request-response-description exists
21:16:57 Failed asserting that false is true.
21:16:57 
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:51
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/structure/ApiDocumentationTest.php:80
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/tests/phpunit/MediaWikiTestCase.php:399
21:16:57 /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/maintenance/doMaintenance.php:111
21:16:57

Details

Related Gerrit Patches:
mediawiki/extensions/SocialProfile : masterAdd missing API i18n messages:

Event Timeline

Reedy created this task.Dec 14 2016, 10:37 PM
Restricted Application added a project: Social-Tools. · View Herald TranscriptDec 14 2016, 10:37 PM
SamanthaNguyen moved this task from Backlog to i18n on the SocialProfile board.
SamanthaNguyen added a project: I18n.
Aklapper added a subscriber: Aklapper.

This is a GCI task now: https://codein.withgoogle.com/tasks/5203015877263360/ (yet to be published) so there's a good chance that a patch will be contributed.

Change 329132 had a related patch set uploaded (by MtDu):
Add missing API i18n messages:

https://gerrit.wikimedia.org/r/329132

Change 329132 merged by jenkins-bot:
Add missing API i18n messages:

https://gerrit.wikimedia.org/r/329132

Reedy closed this task as Resolved.Dec 25 2016, 5:42 PM
Reedy assigned this task to MtDu.