Page MenuHomePhabricator
Create Task
Maniphest T153276

Switching to NWE from VE section edit results in corrupted edits
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We load NWE with full data, but it thinks it's in a section.

Reported here: https://www.mediawiki.org/wiki/Topic:Th7l8unyagx00zek

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditorwmf/1.29.0-wmf.6+4 -1Properly clear this.section when switching from VE
mediawiki/extensions/VisualEditormaster+4 -1Properly clear this.section when switching from VE
Customize query in gerrit

Event Timeline

Esanders created this task.Dec 15 2016, 1:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2016, 1:32 AM
Jdforrester-WMF triaged this task as High priority.Dec 15 2016, 1:34 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Well that's a disappointing regression.

gerritbot added a subscriber: gerritbot.Dec 15 2016, 1:35 AM

Change 327414 had a related patch set uploaded (by Esanders):
Properly clear this.section when switching from VE

https://gerrit.wikimedia.org/r/327414

gerritbot added a project: Patch-For-Review.Dec 15 2016, 1:35 AM
Esanders updated the task description. (Show Details)Dec 15 2016, 1:36 AM
gerritbot added a comment.Dec 15 2016, 4:18 AM

Change 327414 merged by jenkins-bot:
Properly clear this.section when switching from VE

https://gerrit.wikimedia.org/r/327414

gerritbot added a comment.Dec 15 2016, 4:24 AM

Change 327428 had a related patch set uploaded (by Jforrester):
Properly clear this.section when switching from VE

https://gerrit.wikimedia.org/r/327428

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 15 2016, 5:00 AM
gerritbot added a comment.Dec 15 2016, 7:28 PM

Change 327428 merged by jenkins-bot:
Properly clear this.section when switching from VE

https://gerrit.wikimedia.org/r/327428

Stashbot added a subscriber: Stashbot.Dec 15 2016, 7:34 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-15T19:34:42Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.6/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js: SWAT [[gerrit:327428|Properly clear this.section when switching from VE]] T153276 (duration: 00m 39s)

Jdforrester-WMF closed this task as Resolved.Dec 15 2016, 7:35 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)); removed Patch-For-Review.

Now deployed to wmf.6, so will be fixed everywhere within the next hour or so.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL