Page MenuHomePhabricator

Switching to NWE from VE section edit results in corrupted edits
Closed, ResolvedPublic1 Story Points

Description

We load NWE with full data, but it thinks it's in a section.

Reported here: https://www.mediawiki.org/wiki/Topic:Th7l8unyagx00zek

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : wmf/1.29.0-wmf.6Properly clear this.section when switching from VE
mediawiki/extensions/VisualEditor : masterProperly clear this.section when switching from VE

Event Timeline

Esanders created this task.Dec 15 2016, 1:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2016, 1:32 AM
Jdforrester-WMF triaged this task as High priority.Dec 15 2016, 1:34 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Well that's a disappointing regression.

Change 327414 had a related patch set uploaded (by Esanders):
Properly clear this.section when switching from VE

https://gerrit.wikimedia.org/r/327414

Esanders updated the task description. (Show Details)Dec 15 2016, 1:36 AM

Change 327414 merged by jenkins-bot:
Properly clear this.section when switching from VE

https://gerrit.wikimedia.org/r/327414

Change 327428 had a related patch set uploaded (by Jforrester):
Properly clear this.section when switching from VE

https://gerrit.wikimedia.org/r/327428

Change 327428 merged by jenkins-bot:
Properly clear this.section when switching from VE

https://gerrit.wikimedia.org/r/327428

Mentioned in SAL (#wikimedia-operations) [2016-12-15T19:34:42Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.6/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js: SWAT [[gerrit:327428|Properly clear this.section when switching from VE]] T153276 (duration: 00m 39s)

Jdforrester-WMF closed this task as Resolved.Dec 15 2016, 7:35 PM
Jdforrester-WMF assigned this task to Esanders.

Now deployed to wmf.6, so will be fixed everywhere within the next hour or so.