Page MenuHomePhabricator

"mark all as visited" appears temporarily grayed/disabled after a refresh following a watchlist reset
Closed, ResolvedPublic

Description

When I click confirm, the magical Javascript bar runs to 100%, and then disappears. As does the original "mark all as visited". (This is surely a bug.)

When I refresh the page after doing so, "mark all as visited" appears grayed out and is not clickable (for a while--I don't know how long, but after enough time/refreshing/articles unvisited, it becomes clickable again).

It's not a script or gadget. All of mine are turned off (due to troubleshooting related to WE 2017).

Firefox 50.1.0 on Windows 10.

Event Timeline

Izno created this task.Dec 16 2016, 1:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2016, 1:06 AM
Sn1per added a comment.EditedDec 16 2016, 1:13 AM

The disappearing part (for both the progress bar and the button) was part of the design. The loading bar disappears when it's done, and the button disappears as well. The button disappears because with the original form-submission reset behavior, new watchlist items would also show up when the watchlist was reset. However, the new JS reset does not load new items. Therefore, clicking the button after the initial click would in theory mark new watchlist changes as visited, but would not display said changes or show any visual change or indication, which could be confusing. (see https://gerrit.wikimedia.org/r/#/c/326242/)

The button graying out/disabling is strange and I'm not sure if it has to do with this new enhancement. It doesn't seem to happen on my end. (Fedora 25, Chrome 55)

TheVoidwalker added a subscriber: TheVoidwalker.EditedDec 16 2016, 1:17 AM

Check to make sure that pages are marked as visited, the change had made it so that the page marks stuff as visited without reloading (possibly).
No idea why they made it remove the button though.

Sn1per renamed this task from Clicking confirm causes original "mark all pages as visited" to disappear to "mark all as visited" appears temporarily grayed/disabled after a refresh following a watchlist reset.Dec 16 2016, 1:20 AM
Sn1per updated the task description. (Show Details)

Also, I suggested a script here, which replicates the functionality without using a confirmation button.

Legoktm reassigned this task from Sn1per to Fomafix.Dec 16 2016, 8:00 AM
Legoktm added subscribers: Sn1per, Legoktm.

This bug has been fixed in https://gerrit.wikimedia.org/r/#/c/327574/, but we'll need to backport it.

Samtar added a subscriber: Samtar.Dec 16 2016, 9:29 AM

Is this fixed? I've now got a watchlist with some unread items in but the "Mark all pages as visited" button is greyed out - purging on it's own doesn't seem to fix it, but if I close and reopen the tab and then do a purge it seems to clear it... [Windows 10, Firefox 51.0b7]

It's not deployed yet.

Mentioned in SAL (#wikimedia-operations) [2016-12-16T16:35:36Z] <legoktm@tin> Synchronized php-1.29.0-wmf.6/resources/src/mediawiki.special/mediawiki.special.watchlist.js: Revert confirmation button and apply other fixes - T153389 T153438 (duration: 00m 39s)

Mentioned in SAL (#wikimedia-operations) [2016-12-16T16:36:34Z] <legoktm@tin> Synchronized php-1.29.0-wmf.6/resources/Resources.php: Revert confirmation button and apply other fixes - T153389 T153438 (duration: 00m 39s)

Legoktm closed this task as Resolved.Dec 16 2016, 4:43 PM