Page MenuHomePhabricator
Create Task
Maniphest T153424

OAuth API fail
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Some (not all!) Wikimedia servers die with an error when performing API actions via OAuth. Instead of the requested JSON, they return a HTML error:

PHP fatal error: Call to undefined method ApiUsageException::newWithMesage()

There is an obvious typo here...?

Logstash board: https://logstash.wikimedia.org/goto/33e9ab2aaa6298692b493cc9a039d5a8

Over 24 hours:

  • ~ 2000 entries in mediawiki bucket
  • ~ 4000 entries in hhvm bucket

Details

SubjectRepoBranchLines +/-
Fix typo in function namemediawiki/extensions/OAuthwmf/1.29.0-wmf.6+1 -1
Fix typo in function namemediawiki/extensions/OAuthmaster+1 -1
Customize query in gerrit

Event Timeline

Magnus created this task.Dec 16 2016, 9:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2016, 9:20 AM
Magnus triaged this task as Unbreak Now! priority.Dec 16 2016, 9:20 AM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptDec 16 2016, 9:20 AM
Magnus added a comment.Dec 16 2016, 9:21 AM

Addendum: Observed on wikidata, with [action] => query, [meta] => userinfo; probably affects other API calls as well. Again, some servers seem to work, others don't.

gerritbot subscribed.Dec 16 2016, 10:10 AM

Change 327713 had a related patch set uploaded (by Alex Monk):
Fix typo in function name

https://gerrit.wikimedia.org/r/327713

gerritbot added a project: Patch-For-Review.Dec 16 2016, 10:10 AM
hashar added a project: Wikimedia-production-error.Dec 16 2016, 10:22 AM
hashar updated the task description. (Show Details)
Krenair subscribed.Dec 16 2016, 10:27 AM

@Magnus, can you provide a script to reproduce the issue?

Krenair added a comment.Dec 16 2016, 10:31 AM

Introduced in https://gerrit.wikimedia.org/r/#/c/321439/

gerritbot added a comment.Dec 16 2016, 10:32 AM

Change 327713 merged by jenkins-bot:
Fix typo in function name

https://gerrit.wikimedia.org/r/327713

gerritbot added a comment.Dec 16 2016, 10:33 AM

Change 327714 had a related patch set uploaded (by Alex Monk):
Fix typo in function name

https://gerrit.wikimedia.org/r/327714

Magnus added a comment.EditedDec 16 2016, 10:34 AM

This works sometimes, but not others:
https://tools.wmflabs.org/widar/?test=1
If you see some chrome and JSON, it's fine, otherwise, WMF error messages.

Still broken for me

gerritbot added a comment.Dec 16 2016, 10:35 AM

Change 327714 merged by jenkins-bot:
Fix typo in function name

https://gerrit.wikimedia.org/r/327714

Krenair closed this task as Resolved.Dec 16 2016, 10:42 AM
Krenair claimed this task.

Thanks @Magnus, that link was useful.

Magnus added a comment.Dec 16 2016, 10:46 AM

Works for me now, thanks!

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 16 2016, 11:00 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits