Page MenuHomePhabricator

Make DispatchingServiceFactory create EntityIdParser itself, not depend on WikibaseClient to get it
Closed, DeclinedPublic

Description

Currently DispatchingServiceFactory uses WikibaseClient to get a correctly configured DispatchingEntityIdParser instance. This leads to DispatchingServiceFactory depend on the top-level factory, which is bad.
DispatchingServiceFactory should be able to instantiate the "basic" EntityIdParser itself. For this it should get "entity id builder" definitions which are configured in the particular setup.

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
StalledNone
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedWMDE-leszek
ResolvedWMDE-leszek
DeclinedNone

Event Timeline

WMDE-leszek created this task.EditedDec 16 2016, 9:31 AM

Would injecting EntityTypeDefinitions instance into DispatchingServiceFactory be a reasonable solution to deal with the issue?

Ladsgroup renamed this task from Make DispatchingServiceFactory create EntityIdParser itself, not depend on WiikibaseClient to get it to Make DispatchingServiceFactory create EntityIdParser itself, not depend on WikibaseClient to get it.Jan 4 2017, 10:35 AM
WMDE-leszek lowered the priority of this task from Normal to Low.Mar 1 2018, 9:40 AM
Addshore closed this task as Declined.Wed, Oct 30, 4:07 PM
Addshore added a subscriber: Addshore.

DispatchingServiceFactory doesnt exist