Page MenuHomePhabricator
Create Task
Maniphest T153427

Make DispatchingServiceFactory create EntityIdParser itself, not depend on WikibaseClient to get it
Closed, DeclinedPublic
Actions

Description

Currently DispatchingServiceFactory uses WikibaseClient to get a correctly configured DispatchingEntityIdParser instance. This leads to DispatchingServiceFactory depend on the top-level factory, which is bad.
DispatchingServiceFactory should be able to instantiate the "basic" EntityIdParser itself. For this it should get "entity id builder" definitions which are configured in the particular setup.

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 ResolvedLydia_PintscherT146637 Wikidata 2016 Q4 goals
 ResolvedLydia_PintscherT150179 Wikidata 2017 Q1 goals
 ResolvedLydia_PintscherT76007 [Epic] add ability to link/refer to foreign items and properties (federation)
 ResolvedLydia_PintscherT149580 Allow access to entity data stored on "foreign" repositories (federation)
 ResolvedWMDE-leszekT155623 Allow optional use of data retrieval services from Client in Repo
 ResolvedWMDE-leszekT148141 Use dispatching services in Client
 DeclinedNoneT153427 Make DispatchingServiceFactory create EntityIdParser itself, not depend on WikibaseClient to get it

Event Timeline

WMDE-leszek created this task.EditedDec 16 2016, 9:31 AM

Would injecting EntityTypeDefinitions instance into DispatchingServiceFactory be a reasonable solution to deal with the issue?

Ladsgroup renamed this task from Make DispatchingServiceFactory create EntityIdParser itself, not depend on WiikibaseClient to get it to Make DispatchingServiceFactory create EntityIdParser itself, not depend on WikibaseClient to get it.Jan 4 2017, 10:35 AM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.May 5 2017, 12:49 PM
WMDE-leszek edited projects, added User-WMDE-leszek; removed Wikidata-Former-Sprint-Board.Oct 5 2017, 8:05 AM
Lydia_Pintscher moved this task from consider for next sprint to ready to go on the Wikidata board.Dec 18 2017, 2:38 PM
WMDE-leszek lowered the priority of this task from Medium to Low.Mar 1 2018, 9:40 AM
Addshore closed this task as Declined.Oct 30 2019, 4:07 PM
Addshore subscribed.

DispatchingServiceFactory doesnt exist

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL