Page MenuHomePhabricator
Create Task
Maniphest T153481

New WikiText Editor fails when trying to edit articles with editintros
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

If I enable the new WikiText Editor on English Wikipedia and click the "edit" tab on the Barack Obama article, it does nothing (besides changing the URL). I don't get an editing interface or an error (even in the console). It just continues to show the Barack Obama article as if nothing had happened.

Details

SubjectRepoBranchLines +/-
Don't block VE/NWE from loading if 'editintro' is specifiedmediawiki/extensions/VisualEditormaster+0 -2
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Dec 16 2016, 7:05 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 16 2016, 7:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ryasmeen subscribed.Dec 16 2016, 10:08 PM

It's loading for me, not sure if I am missing any step here.

Screen Shot 2016-12-16 at 2.07.25 PM.png (643×1 px, 244 KB)

kaldari added a comment.Dec 17 2016, 1:51 AM

@Ryasmeen: I don't know how you got to that URL. If you click the edit button, it should have sent you to:
https://en.wikipedia.org/w/index.php?title=Barack_Obama&editintro=Template%3ABLP_editintro&veaction=editsource
...not...
https://en.wikipedia.org/w/index.php?title=Barack_Obama&veaction=editsource
Maybe you have some special gadget installed that strips editintro templates?

Ryasmeen added a comment.EditedDec 17 2016, 5:49 AM

Ah yeah, I had FormWizard enabled. I can reproduce it now after disabling that gadget.

Esanders merged a task: T153538: NWE: Add support for editintro and preload.Dec 31 2016, 3:18 PM
Esanders added a subscriber: Schnark.
Esanders subscribed.Dec 31 2016, 3:23 PM

NB Actually supporting editintro's in VE is T56029.

gerritbot subscribed.Dec 31 2016, 3:24 PM

Change 329794 had a related patch set uploaded (by Esanders):
Don't block VE/NWE from loading if 'editintro' is specified

https://gerrit.wikimedia.org/r/329794

gerritbot added a project: Patch-For-Review.Dec 31 2016, 3:24 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jan 3 2017, 6:22 PM
Jdforrester-WMF assigned this task to Esanders.Jan 3 2017, 6:36 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Jan 3 2017, 8:13 PM

Change 329794 merged by jenkins-bot:
Don't block VE/NWE from loading if 'editintro' is specified

https://gerrit.wikimedia.org/r/329794

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 3 2017, 9:00 PM
Jdforrester-WMF closed this task as Resolved.Jan 3 2017, 9:04 PM
Jdforrester-WMF removed projects: Patch-For-Review, Contributors-Team.
Ryasmeen added a project: Verified.Jan 25 2017, 2:46 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 25 2017, 2:46 AM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Feb 4 2017, 1:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL