Using $element.closest( 'html' ).length to check whether an element is attached is slow
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Dec 16 2016, 7:57 PM

Description

Using $element.closest( 'html' ).length to check whether an element is attached is slow. $.contains is ~10 times faster. https://jsfiddle.net/5o9sLbbs/

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	TextInputWidget: Use Element#isElementAttached	oojs/ui	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T71799 Editing a transclusion with many templates hangs the browser
Open	None	T134814 Multi-part transclusion dialog a little slow to load
Resolved	matmarex	T153490 Using $element.closest( 'html' ).length to check whether an element is attached is slow

Event Timeline

matmarex created this task.Dec 16 2016, 7:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2016, 7:57 PM

matmarex added a parent task: T134814: Multi-part transclusion dialog a little slow to load.Dec 16 2016, 7:58 PM

Change 327768 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Use Element#isElementAttached

https://gerrit.wikimedia.org/r/327768

gerritbot added a project: Patch-For-Review.Dec 16 2016, 7:58 PM

Jdforrester-WMF closed this task as Resolved.Dec 17 2016, 2:42 AM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.18.3 on the OOUI board.

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.18.3); removed OOUI.

Jdforrester-WMF edited projects, added Performance Issue; removed Patch-For-Review.

Change 327768 merged by jenkins-bot:
TextInputWidget: Use Element#isElementAttached