Page MenuHomePhabricator
Create Task
Maniphest T153518

API RevisionDelete forces old-style booleans
Closed, ResolvedPublic
Actions

Description

The getApiData functions in the various revision deletion classes forcibly use formatversion=1-style booleans rather than following the user's choice (e.g., "userhidden": "" instead of "userhidden": true).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix RevDel API output for formatversion=2mediawiki/coremaster+23 -29
Customize query in gerrit

Event Timeline

RobinHood70 created this task.Dec 17 2016, 3:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2016, 3:42 AM
Anomie added a project: good first task.Dec 17 2016, 5:04 PM
Anomie subscribed.

This should be fixed, even though it's a breaking change for formatversion=2 users.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 17 2016, 5:04 PM
Anomie moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.Dec 17 2016, 5:05 PM
gerritbot subscribed.Dec 19 2016, 4:37 PM

Change 328190 had a related patch set uploaded (by Anomie):
Fix RevDel API output for formatversion=2

https://gerrit.wikimedia.org/r/328190

gerritbot added a project: Patch-For-Review.Dec 19 2016, 4:37 PM
Anomie claimed this task.Dec 19 2016, 4:38 PM
Anomie moved this task from Needs Code to Needs Review on the MediaWiki-Action-API board.
gerritbot added a comment.Dec 19 2016, 7:16 PM

Change 328210 had a related patch set uploaded (by Anomie):
ApiMove: Fix fatal when attempting to move to a namespace with no talkpages

https://gerrit.wikimedia.org/r/328210

RobinHood70 added a comment.Dec 19 2016, 7:18 PM

Anomie: That fix is filed under the wrong task.

gerritbot added a comment.Dec 19 2016, 11:06 PM

Change 328190 merged by jenkins-bot:
Fix RevDel API output for formatversion=2

https://gerrit.wikimedia.org/r/328190

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 20 2016, 12:00 AM
Anomie closed this task as Resolved.Dec 21 2016, 3:45 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits