Maniphest T153531

Wrong id used for 'colspan' in content/NewsletterDiffEngine.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	01tonythomas
	Dec 17 2016, 9:01 AM

Project Tags

Referenced Files

None

Subscribers

Description

This task is about the Newsletter extension.

Possibly because the author was copying in ContentHandler things from the MassMessage extension.

You can find this in https://phabricator.wikimedia.org/diffusion/ENLT/browse/master/includes/content/NewsletterDiffEngine.php;91bcd708bb9c5db77428c599f977cdc9d78beffa$54 .
Please change that to something like mw-newsletter-diffpublishersheader

Mentors: @01tonythomas

Related Objects

Mentioned Here: T153530: Wrong message-key used in NewsletterDiffEngine.php

Event Timeline

01tonythomas created this task.Dec 17 2016, 9:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2016, 9:01 AM

Imported as https://codein.withgoogle.com/dashboard/tasks/5730923393843200/ Waiting for @Aklapper to publish.

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Dec 17 2016, 3:24 PM

01tonythomas moved this task from Backlog to Google Code In 2016 on the MediaWiki-extensions-Newsletter board.Dec 18 2016, 2:59 PM

Aklapper updated the task description. (Show Details)Dec 19 2016, 11:08 AM

Hasn't this been already fixed with T153530?
See https://phabricator.wikimedia.org/rENLTca47570a1121f9dd008496eaadd3307bfdf99de3#e8777708

Edit: Seems like yes, I will claim this task as resolved :)

divadsn closed this task as Resolved.Dec 22 2016, 12:02 PM

divadsn claimed this task.

Qgil awarded a token.Dec 22 2016, 9:26 PM

True. Thank you!