Page MenuHomePhabricator
Create Task
Maniphest T153556

OATHAuth token textbox must always be LTR
Closed, ResolvedPublic
Actions

Description

Right now it is show in RTL in RTL wikis. The code is always a six digit number in Latin (English) characters; this textbox should never be RTL.

Details

SubjectRepoBranchLines +/-
Make token fields always ltrmediawiki/extensions/OATHAuthmaster+3 -0
The direction of token field should be ltrmediawiki/extensions/OATHAuthmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Huji created this task.Dec 17 2016, 8:19 PM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptDec 17 2016, 8:19 PM
Huji triaged this task as Lowest priority.Dec 17 2016, 8:20 PM
Huji renamed this task from 2FA textbox for the 6 digit code must always be LTR to OATHAuth token textbox must always be LTR.Dec 18 2016, 1:04 AM
Huji removed Huji as the assignee of this task.
Aklapper added a project: RTL.Dec 18 2016, 8:58 AM
Restricted Application added a project: I18n. · View Herald TranscriptDec 18 2016, 8:58 AM
TheDJ created subtask T153636: OOUI form fields do not set the dir attribute of textfields.Dec 19 2016, 10:15 AM
gerritbot subscribed.Dec 19 2016, 10:19 AM

Change 328152 had a related patch set uploaded (by TheDJ):
The direction of token field should be ltr

https://gerrit.wikimedia.org/r/328152

gerritbot added a project: Patch-For-Review.Dec 19 2016, 10:19 AM
TheDJ subscribed.Dec 19 2016, 10:20 AM

Note that the patch is blocked on a fix for ooui htmlforms

TheDJ moved this task from Backlog to In Progress on the MediaWiki-extensions-OATHAuth board.Dec 19 2016, 10:21 AM
matmarex closed subtask T153636: OOUI form fields do not set the dir attribute of textfields as Resolved.Jan 19 2017, 8:13 PM
TheDJ claimed this task.Apr 21 2017, 7:16 PM
gerritbot added a comment.Aug 10 2017, 10:19 PM

Change 328152 abandoned by TheDJ:
The direction of token field should be ltr

https://gerrit.wikimedia.org/r/328152

TheDJ removed TheDJ as the assignee of this task.Aug 10 2017, 10:20 PM
Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:30 PM
Amire80 moved this task from Untriaged to RTL on the I18n board.Feb 26 2018, 10:40 AM
• Phabricator_maintenance moved this task from Doing to Backlog on the good first task board.Sep 24 2018, 9:57 AM
Reedy claimed this task.Jun 18 2019, 10:25 PM
Reedy removed a project: Patch-For-Review.
gerritbot added a comment.Jun 18 2019, 10:36 PM

Change 517760 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OATHAuth@master] Make token fields always ltr

https://gerrit.wikimedia.org/r/517760

gerritbot added a project: Patch-For-Review.Jun 18 2019, 10:36 PM
gerritbot added a comment.Jun 19 2019, 12:41 AM

Change 517760 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] Make token fields always ltr

https://gerrit.wikimedia.org/r/517760

Reedy closed this task as Resolved.Jun 19 2019, 12:50 AM
Reedy removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 19 2019, 1:00 AM
TheDJ added a comment.Jun 20 2019, 9:03 AM

thx @Reedy

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL