Page MenuHomePhabricator

Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28
Closed, DuplicatePublic

Description

When running this branch, we get:

PHP Fatal Error: Call to undefined method SkinVector::commentBlock()

It looks like there might be some fixes in the master branch. Maybe they should be backported?

Event Timeline

labster created this task.Dec 17 2016, 9:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2016, 9:24 PM

See https://gerrit.wikimedia.org/r/#/c/325799/ please. Already fixed in master branch.

labster changed the task status from Duplicate to Declined.Dec 17 2016, 10:43 PM

If you're not going to fix the problem, don't just close the ticket resolved. I'm taking this to mean that you're declining to fix this issue.

It is fixed, if you look at the link and the task this is merged into. Just no one has merged the fix on the REL1_28 branch. If you carn't be bovered to wait until the patch is merged then you will be waiting a long time.

labster added a comment.EditedDec 17 2016, 10:49 PM

Ah, OK. You just said "already fixed in master" and assigned a duplicate task that is already closed, but didn't say that there was a fix for this branch. I assumed that you didn't understand the request.