| Guycn2 | |
| Dec 18 2016, 6:31 PM |
| F6628702: Screen Shot 2017-03-16 at 9.09.04 AM.png | |
| Mar 16 2017, 4:09 PM |
Currently, all descriptions on "Preferences => Beta features" have a period, except for Hovercards's description.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| i18n: changes to Page previews in beta tab of preferences | mediawiki/extensions/Popups | master | +2 -2 |
Should we also take this opportunity to change the name in Beta Features from "Hovercards" to "Page previews" ?
Change 338006 had a related patch set uploaded (by Jdlrobson):
i18n: changes to Page previews in beta tab of preferences
Nirzar suggests changing from Hovercards (https://phabricator.wikimedia.org/T153599#3031069) but @ovasileva P should have final decision. Ping @Quiddity in case you have any views on this?
@Jdlrobson - sounds good, let's switch it. I will make a note in the description for myself to update the documentation reflecting the change.
It seems there is more up to this than just adding the period (may someone change the title?).
https://gerrit.wikimedia.org/r/338006 fixes both the issues so this just needs someone to verify and merge.
Okay, then I got this wrong. Finding someone to review this can't be that hard, can it? ;)
This appears to not be merging blocked by
19:01:53 Background: # features/previews.feature:3 19:01:53 Given I am logged in # mediawiki_selenium-1.7.3/lib/mediawiki_selenium/step_definitions/login_steps.rb:1 19:01:53 Invalid CSRF token. (badtoken) (MediawikiApi::ApiError) 19:01:53 features/previews.feature:4:in `Given I am logged in' 19:01:53 And I have enabled the beta feature # features/support/step_definitions/common_steps.rb:3 19:01:53 And I am on the test page # features/support/step_definitions/common_steps.rb:7 19:01:53
This error is unrelated to change. We may need to open a blocking task to debug this as all merges to Popups may be being blocked now.
Change 338006 merged by jenkins-bot:
[mediawiki/extensions/Popups] i18n: changes to Page previews in beta tab of preferences
@EddieGP: Not so fast ;) Thanks for picking up this task. @ovasileva: The change should be deployed to the Beta Cluster by 11:30 AM UTC.
FTR I've deliberately skipped the Needs QA column as @EddieGP's change was strictly limited to changing a message.
@phuedx Is this something Reading-Team-Workflow specific? Usually I'm closing tasks when the patch got merged, so I don't really know why that was wrong. I saw you moved this to "Ready for Signoff", what exactly does signoff mean here?
I should've explained that I'd moved the task to Ready for Signoff as the Reading Web team's PO (@ovasileva) should take a look at the change in action.
