Page MenuHomePhabricator

New topic notification double parses?
Closed, ResolvedPublic

Description

The notification for https://www.mediawiki.org/wiki/Topic:Thfmjii5qc7isoah had the {{speedy}} and {{delete}} text expanded - but if you look at the page, that wasn't supposed to happen.

Event Timeline

Krenair created this task.Dec 18 2016, 11:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krenair updated the task description. (Show Details)Dec 18 2016, 11:19 PM

Change 328166 had a related patch set uploaded (by Catrope):
Always use plaintextParams() with getContentSnippet() to prevent double-parsing

https://gerrit.wikimedia.org/r/328166

Change 328166 merged by jenkins-bot:
Always use plaintextParams() with getContentSnippet() to prevent double-parsing

https://gerrit.wikimedia.org/r/328166

Checked in betalabs - {{tlx|speedy}} and {{tlx|delete}} are not expanded in notifications.

@Catrope please review the following to confirm that it's a correct behavior:

  1. ET19 creates a new page Mavetuna19
  2. Etonkovidova via Special:NewPagesFeed adds to Mavetuna19 {{speedy deletion-no context}}
  3. ET19 receives two notifications for that:
    • The page Mavetuna19‬ was marked for deletion. Tag: speedy deletion-no context.
    • A new topic was created on your talk page: "Speedy deletion nomination of Mavetuna19‬" {{subst:Empty-warn-NPF|Mavetuna19}}

I think that's because we never imported the new templates from 891b3b6b5109b20c924fac253f9d1ce13af2ae9a into beta labs. I just did that, so if you try this again it should work. https://en.wikipedia.beta.wmflabs.org/wiki/Template:Empty-warn-NPF , among many others, now exists.

Checked in betalabs - templates are displayed properly in notificaitons for the case when a page was reviewed via Special:NewPagesFeed.
Note: a user name being not properly displayed is a known issue (it occurs only on Flow enabled user talk pages).

  • QA recommendation: Resolve. **
jmatazzoni closed this task as Resolved.Jan 5 2017, 6:21 PM