Page MenuHomePhabricator

Timed media handler transcode status often has weird status messages
Closed, ResolvedPublic

Description

See eg. https://commons.wikimedia.org/wiki/File:5-1-15-_White_House_Press_Briefing.webm

Added to Job queue [INVALID] ago
Started [INVALID] ago. comma

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2016, 11:24 AM
zhuyifei1999 added a project: Commons.

(Self-assigning because I think I can figure this out)

With a few evals on a vagrant instance, this seems quite related to T152603: Invalid parameter for message "api-help-permissions-granted-to"

Apparently the patch for the above task fixed the usage of wfMessage( 'timedmedia-in-job-queue' )->params( Message::listParam( [ '1 second' ], 'comma' ) ), but not wfMessage( 'timedmedia-in-job-queue', Message::listParam( [ '1 second' ], 'comma' ) ), is this intended?

Change 328366 had a related patch set uploaded (by Zhuyifei1999):
wfMessage: use Message::params() to handle all the message parameters

https://gerrit.wikimedia.org/r/328366

Anomie added a comment.EditedDec 20 2016, 2:28 PM

Looks like wfMessage() has the same bug as in T152603: Invalid parameter for message "api-help-permissions-granted-to".

The easiest fix would be to change wfMessage( $key, ... ) to be the same as ( new Message( $key ) )->params( ... ) instead of trying to duplicate the handling that ->params() already does in order to call new Message( $key, $params ).

Edit: Ha, you beat me to that realization.

Edit: Ha, you beat me to that realization.

lol

Kjetil added a subscriber: Kjetil.Dec 20 2016, 8:01 PM

Change 328366 merged by jenkins-bot:
wfMessage: use Message::params() to handle all the message parameters

https://gerrit.wikimedia.org/r/328366

matmarex closed this task as Resolved.Dec 21 2016, 8:20 AM
matmarex removed a project: Patch-For-Review.
matmarex added a subscriber: matmarex.

This will be deployed to Wikimedia wikis the week of January 2nd, there are no deployments until then due to holidays. I don't think it's a major issue, so it can wait.