They are both blue boxes with a white check mark in them.
Instead, disabled ones should look grey.
| Huji | |
| Dec 20 2016, 2:05 PM |
| F5110062: BEFORE.PNG | |
| Dec 20 2016, 2:59 PM |
| F5110061: After.PNG | |
| Dec 20 2016, 2:59 PM |
They are both blue boxes with a white check mark in them.
Instead, disabled ones should look grey.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | Huji | T150079 Special:BotPasswords Visual indication between checkboxes and corresponding text should be clearer | |||
| Invalid | Huji | T153752 Disabled checked boxes in OOUI look identical to checked boxes that are not disabled |
I doubt this is a OOjs issue, rather i suspect it has to do with htmlforms not translating the disabled attribute correctly or something. See also T153636: OOUI form fields do not set the dir attribute of textfields for a similar situation regarding the dir attribute.
Change 328370 had a related patch set uploaded (by Huji):
Disabled checked checkboxes in OOjs-UI should look grey
@TheDJ: I manually tweaked the HTML element and made the checkbox disabled (i.e. didn't let HTMLForm get in the way). It was still blue; I explored the CSS and turns out there was no rule for checked disabled checkboxes, so I added one.
This could be programmatically a special case not covered by OOjs UI yet (but probably not recommended or desired either). If a CheckboxWidget is set to disabled, the corresponding label should be disabled as well. Not just the checkbox. That's the current implementation (see “CheckboxInputWidget (disabled)”.
Change 328370 abandoned by Huji:
Disabled checked checkboxes in OOjs-UI should look grey
Reason:
Wrong repo. Will submit to the correct repo.
Perhaps I should ask before I submit a new patch. My understanding is that if a checkbox is checked, it's parent element will be assigned the classes oo-ui-widget-enabled. So enabled here has to do with checked or not checked. Is that correct?
Change 328393 had a related patch set uploaded (by Huji):
Disabled checked checkboxes in OOjs-UI should look grey
Change 328393 abandoned by Huji:
Disabled checked checkboxes in OOjs-UI should look grey
Reason:
You are correct; I was initiating the element incorrectly. Abandoning.