Page MenuHomePhabricator

Blocked and deleted users appear at the TopUsers page
Closed, DeclinedPublic

Description

After I've updated my wiki and my extensions from 1.27 to the master build I seem to notice that for some reason blocked users and people whose accounts have been deleted with the UserMerge extension appear at the Special:TopUsers page, which didn't happen in the previous versions.

My MediaWiki version: 1.29.0-alpha (5b211eb)
My SocialProfile version: 1.10 (72f8ce3)
My UserMerge version: 1.10.0 (720ef77)

Event Timeline

SamanthaNguyen moved this task from Backlog to Bugs on the SocialProfile board.
SamanthaNguyen added a subscriber: ashley.

So I don't get how that could happen. If you look at TopUsersPoints::execute() (in /extensions/SocialProfile/UserStats/TopUsers.php) -- or for that matter, any other Special:Top* page's source code -- you'll notice there are explicit checks in place to ensure that the displayed users are:

  1. not blocked
  2. real, existing accounts (=not deleted or merged or whatever)
  3. not bots

UserMerge is somewhat of a wild card as user deletion isn't really supported in MediaWiki. Sure, many wikis are using that extension, but it might cause strange things to happen.

I'm guessing this is somehow related to the fact you're running MediaWiki 1.29alpha instead of 1.28, the latest stable version of MW and the only one currently officially supported by social tools, because this issue most definitely doesn't happen on 1.28. I blocked the account Vector on my test wiki for a day, and as you can see, the account is not displayed on the list of top users. Are you able to test with another 1.29 wiki? Even better, can you also test out 1.28?

Closing this, since everything under Social-Tools (including SocialProfile ) is developed for master, not alpha versions of mediawiki.