Page MenuHomePhabricator
Create Task
Maniphest T153767

Unify basic local repository settings and foreign repository settings into a single setting (days: 8)
Closed, ResolvedPublic
Actions

Description

Local repository is configured in $wgWBClientSettings using settgings: repoDatabase, entityNamespaces, repoConceptBaseUri, whereas foreign repositories are conigured using array setting "foreignRepositories". Those should be unified to a single "repositories" setting (local repo being empty-string repository there).

Patch-For-Review:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Integrate all Client's repository settings into a single settingmediawiki/extensions/Wikibasemaster+392 -105
Integrate all Client's repository settings into a single settingmediawiki/extensions/Wikibasemaster+392 -105
[WIP] Integrate repository configuration of WikibaseRepo into single settingmediawiki/extensions/Wikibasemaster+103 -67
Rename foreignRepositories config in client to repositoriesmediawiki/extensions/Wikibasemaster+6 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 ResolvedLydia_PintscherT146637 Wikidata 2016 Q4 goals
 ResolvedLydia_PintscherT150179 Wikidata 2017 Q1 goals
 ResolvedLydia_PintscherT76007 [Epic] add ability to link/refer to foreign items and properties (federation)
 OpenNoneT185748 Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['repositories']
 ResolvedLydia_PintscherT153767 Unify basic local repository settings and foreign repository settings into a single setting (days: 8)
 ResolvedWMDE-leszekT185200 Change configs in beta to conform with the new repo settings
 OpenNoneT185310 Deprecate repoUrl and move it to $wgWBClientSettings['repositories']
 OpenNoneT185755 Change configs in prod to conform with the new repo settings

Event Timeline

daniel created this task.Dec 20 2016, 5:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2016, 5:44 PM
WMDE-leszek added a comment.Dec 21 2016, 8:13 AM

Probably the setting could then be renamed to "repositories"?

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.May 5 2017, 12:48 PM
Lydia_Pintscher removed a project: Wikidata-Former-Sprint-Board.Nov 21 2017, 8:57 AM
gerritbot subscribed.Dec 26 2017, 7:46 PM

Change 400239 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Rename foreignRepositories config in client to repositories

https://gerrit.wikimedia.org/r/400239

gerritbot added a project: Patch-For-Review.Dec 26 2017, 7:46 PM
Ladsgroup claimed this task.Dec 26 2017, 7:46 PM
Ladsgroup added a project: Wikidata-Sprint-2017-12-20.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 26 2017, 7:46 PM
Ladsgroup moved this task from Backlog to Review on the Wikidata-Sprint-2017-12-20 board.Dec 26 2017, 7:46 PM
gerritbot added a comment.Dec 27 2017, 4:45 PM

Change 400415 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Use foreignRepositories settings in clients instead of repoXXX

https://gerrit.wikimedia.org/r/400415

Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Dec 28 2017, 11:09 PM
WMDE-leszek added a project: Wikidata-Sprint-2018-01-03.Jan 2 2018, 1:45 PM
WMDE-leszek moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-03 board.
Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Jan 2 2018, 2:51 PM
WMDE-leszek claimed this task.Jan 4 2018, 2:57 PM
WMDE-leszek moved this task from Review to In Progress on the Wikidata-Sprint-2018-01-03 board.
WMDE-leszek added a subscriber: Ladsgroup.
WMDE-leszek added a comment.Jan 5 2018, 2:40 PM
This comment was removed by WMDE-leszek.
gerritbot added a comment.Jan 5 2018, 4:54 PM

Change 402386 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] [WIP] Integrate repository configuration of WikibaseRepo into single setting

https://gerrit.wikimedia.org/r/402386

gerritbot added a comment.Jan 5 2018, 8:53 PM

Change 400239 abandoned by Ladsgroup:
Rename foreignRepositories config in client to repositories

Reason:
Merged into other patches

https://gerrit.wikimedia.org/r/400239

WMDE-leszek removed WMDE-leszek as the assignee of this task.Jan 8 2018, 9:10 AM
WMDE-leszek moved this task from In Progress to Review on the Wikidata-Sprint-2018-01-03 board.
WMDE-leszek added a comment.Jan 8 2018, 10:57 AM

Please ignore my previous comment on also integrating Repo component's settings into a single "repositories" setting. Does not seem thought-through. Definitely something to be left out for now. So this is only about the Client's settings.

gerritbot added a comment.Jan 8 2018, 3:28 PM

Change 402386 abandoned by WMDE-leszek:
[WIP] Integrate repository configuration of WikibaseRepo into single setting

https://gerrit.wikimedia.org/r/402386

WMDE-leszek renamed this task from Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] to Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 4).Jan 11 2018, 9:35 AM
WMDE-leszek renamed this task from Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 4) to Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 5).Jan 13 2018, 11:39 AM
WMDE-leszek renamed this task from Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 5) to Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 6).Jan 15 2018, 5:23 PM
WMDE-leszek added a project: Wikidata-Sprint-2018-01-17.Jan 16 2018, 1:49 PM
Lydia_Pintscher moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-17 board.Jan 16 2018, 1:50 PM
WMDE-leszek renamed this task from Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 6) to Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 7).Jan 16 2018, 3:33 PM
gerritbot added a comment.Jan 16 2018, 5:18 PM

Change 400415 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Integrate all Client's repository settings into a single setting

https://gerrit.wikimedia.org/r/400415

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 16 2018, 6:00 PM
WMDE-leszek renamed this task from Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 7) to Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 8).Jan 17 2018, 11:13 AM
WMDE-leszek claimed this task.Jan 17 2018, 1:51 PM
WMDE-leszek moved this task from Review to In Progress on the Wikidata-Sprint-2018-01-17 board.
gerritbot added a comment.Jan 17 2018, 2:54 PM

Change 404679 had a related patch set uploaded (by WMDE-leszek; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Integrate all Client's repository settings into a single setting

https://gerrit.wikimedia.org/r/404679

WMDE-leszek removed WMDE-leszek as the assignee of this task.Jan 17 2018, 3:23 PM
WMDE-leszek moved this task from In Progress to Review on the Wikidata-Sprint-2018-01-17 board.
gerritbot added a comment.Jan 18 2018, 10:24 AM

Change 404679 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Integrate all Client's repository settings into a single setting

https://gerrit.wikimedia.org/r/404679

Ladsgroup moved this task from Review to Done on the Wikidata-Sprint-2018-01-17 board.Jan 18 2018, 10:29 AM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 18 2018, 11:00 AM
Ladsgroup added a comment.Jan 19 2018, 11:00 AM

One note: repoUrl is not deprecated yet, what should we do about it?

thiemowmde removed a project: Patch-For-Review.Jan 22 2018, 11:28 AM
thiemowmde updated the task description. (Show Details)
thiemowmde subscribed.
thiemowmde added a comment.Jan 22 2018, 11:30 AM

@Ladsgroup, should this deprecation be part of acceptance criteria for this ticket? My gut feeling says yes, it should. What's missing to do this?

Ladsgroup added a comment.Jan 23 2018, 5:31 PM

Things need to be done:

  • Deprecated repoUrl and move it to repository definitions, how? I have absolutely no idea.
  • Communicate about this deprecation.
  • Change configs in beta and prod (I tried once and failed miserably)
  • Remove the old config

I think it would be good to seperate them into several tickets so we don't drag it from sprint to sprint. The first and third point already have tickets.

WMDE-leszek added a comment.Jan 26 2018, 11:52 AM

I don't think moving repoUrl (and other stuff, like repoScriptPath, repoArticlePath) is critical. It was meant as part of this task indeed. I am going to make this ticket explicitly for unifying settings to repositories, and create a new repoXXX ticket. It does not need to be worked on right away IMO, though.

WMDE-leszek renamed this task from Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] (days: 8) to Unify basic local repository settings and foreign repository settings into a single setting (days: 8).Jan 26 2018, 11:56 AM
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek added a parent task: T185748: Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['repositories'].

New parent task T185748

Ladsgroup closed subtask T185200: Change configs in beta to conform with the new repo settings as Resolved.Jan 26 2018, 2:58 PM
Lydia_Pintscher closed this task as Resolved.Feb 5 2018, 3:28 PM
Lydia_Pintscher claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits