The localSiteID setting must refer to a site that is known to the SiteLookup service. If this is not the case, a warning should be raised - probably a production warning (wfLogWarning), but at least a devlopment warning (wfWarn).
This warnign existed until it was removed by I1a52ce07943 to fix a problem with qunit tests, see T153729 and T153597. However, that problem would better be addressed by fixing the CI setup, instead of removing the warning that indicates a configuration error.
Change 328504 had a related patch set uploaded (by Daniel Kinzler):
[WIP] Revert "Remove warning about missing site ID"
Change 328504 abandoned by Addshore:
[WIP] Revert "Remove warning about missing site ID"
Reason:
Build is dead
Change 540086 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Log a warning in case of a siteGlobalID misconfiguration
Change 540086 abandoned by Addshore:
[mediawiki/extensions/Wikibase@master] Log a warning in case of a siteGlobalID misconfiguration
Reason:
I'll abandon this then as the version of code in this change now exists merged in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /675525/3/client/WikibaseClient.ServiceWiring.php
I don’t think so:
if ( !$site ) { // TODO we should log some warning here, // but currently that breaks CI (T153729, T153597) return Site::GROUP_NONE; }