Page MenuHomePhabricator
Create Task
Maniphest T153950

Add ChangeOpDeserializer interface for services providing ChangeOps to Api\EditEntity
Closed, ResolvedPublic
Actions

Description

Currently Api\EditEntity hardcodes deserialization details specific to items and properties but not applying at all to the new Lexeme entity type.
We want to move out change op deserialization logic out of this class. There would be classes implementing the common deserialization interface that received a serialized form of change ops, and return entity-type-specific ChangeOps, that could be then used by API EditEntity class.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[WIP] Alternative ChangeOpDeserializer interfacemediawiki/extensions/Wikibasemaster+55 -10
Introduce ChangeOpDeserializer interfacemediawiki/extensions/Wikibasemaster+28 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Dec 22 2016, 3:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2016, 3:39 PM
Ladsgroup renamed this task from Build ChangeOpDeserializer for EditEntity API injectable to Build ChangeOpDeserializer for injectable EditEntity API.Dec 27 2016, 6:49 AM
gerritbot subscribed.Dec 28 2016, 2:47 AM

Change 329376 had a related patch set uploaded (by Ladsgroup):
Intorduce EditEntityApiChangeOpDeserializer interface

https://gerrit.wikimedia.org/r/329376

gerritbot added a project: Patch-For-Review.Dec 28 2016, 2:47 AM
Ladsgroup claimed this task.Dec 28 2016, 2:47 AM
Ladsgroup moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 28 2016, 2:47 AM
Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Dec 28 2016, 11:56 AM
WMDE-leszek renamed this task from Build ChangeOpDeserializer for injectable EditEntity API to Add ChangeOpDeserializer interface for services providing ChangeOps to Api\EditEntity.Dec 29 2016, 3:43 PM
WMDE-leszek updated the task description. (Show Details)

@Ladsgroup: I've edited task description and the title a bit. Please check if it isn't something different than what you had in mind.

WMDE-leszek added a parent task: T152491: Allow the EditEntity API module to work with all types of entities.Dec 29 2016, 3:50 PM
WMDE-leszek mentioned this in T154288: Factor ChangeOps instantiation logic out of Api\EditEntity.Dec 29 2016, 4:00 PM
WMDE-leszek edited parent tasks, added: T154288: Factor ChangeOps instantiation logic out of Api\EditEntity; removed: T152491: Allow the EditEntity API module to work with all types of entities.
gerritbot added a comment.Jan 5 2017, 6:25 PM

Change 329376 merged by jenkins-bot:
Introduce ChangeOpDeserializer interface

https://gerrit.wikimedia.org/r/329376

gerritbot added a comment.Jan 5 2017, 7:06 PM

Change 330698 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
[WIP] Alternative ChangeOpDeserializer interface

https://gerrit.wikimedia.org/r/330698

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Jan 6 2017, 9:05 AM
gerritbot added a comment.Jan 6 2017, 1:04 PM

Change 330698 abandoned by Aleksey Bekh-Ivanov (WMDE):
[WIP] Alternative ChangeOpDeserializer interface

https://gerrit.wikimedia.org/r/330698

thiemowmde closed this task as Resolved.Jan 18 2017, 11:37 AM
thiemowmde moved this task from incoming to in progress on the Wikidata board.
Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.Mar 7 2017, 1:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits