Page MenuHomePhabricator
Create Task
Maniphest T153959

The keyboard shortcut for previewing a page (ctrl-option-p) doesn't do anything on some browsers
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The keyboard shortcut ctrl-option-p is supposed to invoke page preview (in wikitext editors from 2010 and earlier).

On my Mac, within VisualEditor (both visual and wikitext modes), it just types π instead. @Sadads reports that the equivalent command invokes preview on his computer system (with catastrophic consequences: T153937: LOST WORK BUG: If you use the shortcut keyboard command to preview, you lose all your changes.).

This keyboard shortcut should either work everywhere (ideally sans catastrophic consequences, but that's the other bug) or nowhere.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
init.mw.Target: make getSurfaceConfig aware of modesmediawiki/extensions/VisualEditormaster+14 -3
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Dec 22 2016, 6:15 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 22 2016, 6:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DLynch subscribed.Dec 22 2016, 11:07 PM

I can't reproduce this. Can you confirm that you're seeing the preview shortcut in the command help dialog? Also, which browser you're using?

• AlexMonk-WMF mentioned this in T154182: [suggestion] NWE should allow shortcuts like Alt+Shift+P for preview etc..Dec 27 2016, 12:59 PM
Jdforrester-WMF triaged this task as High priority.Jan 3 2017, 8:30 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a project: Browser-Support-Apple-Safari.
Jdforrester-WMF subscribed.

Per the help dialog, this is "^+⎇+P Show preview" which works for me in Chrome and Firefox, but is broken in Safari (surprise).

• Whatamidoing-WMF added a comment.Jan 3 2017, 8:31 PM

I am not seeing the preview shortcut in the command help dialog in Safari 10 or in Firefox 50.

TheDJ subscribed.Jan 3 2017, 9:07 PM

The shortcut for preview is not deployed to production yet maybe ? I see it (and it works) on https://en.wikipedia.beta.wmflabs.org/wiki/UserMergejfvvsc?veaction=editsource but not on production en.wp https://en.wikipedia.org/wiki/UserMergejfvvsc?veaction=editsource

DLynch added a comment.Jan 3 2017, 9:36 PM

@Jdforrester-WMF: It does work in Safari for me, just tested. Did you make a change to the document first? It behaves like the other save-related stuff and no-ops if you don't have any changes yet.

Jdforrester-WMF changed the task status from Open to Stalled.Jan 3 2017, 9:42 PM
Jdforrester-WMF removed a project: Browser-Support-Apple-Safari.

Ah, hmm, yes, looks like I used the wrong shortcut. :-)

OK, now we're back to being bamboozled.

• Elitre renamed this task from The keyboard shortcut for previewing a page (ctrl-option-p) doesn't do anything on a Mac to The keyboard shortcut for previewing a page (ctrl-option-p) doesn't do anything on some browsers.Sep 25 2017, 10:04 AM
• Elitre subscribed.

I changed the description as the relevant keyboard shortcut seems to be not working in FF Nightly as well.

gerritbot subscribed.Oct 10 2017, 8:21 PM

Change 383410 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] init.mw.Target: make getSurfaceConfig aware of modes

https://gerrit.wikimedia.org/r/383410

gerritbot added a project: Patch-For-Review.Oct 10 2017, 8:21 PM
gerritbot added a comment.Oct 10 2017, 10:02 PM

Change 383410 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] init.mw.Target: make getSurfaceConfig aware of modes

https://gerrit.wikimedia.org/r/383410

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 10 2017, 11:00 PM
Jdforrester-WMF closed this task as Resolved.Oct 11 2017, 7:32 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)); removed MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review.

RTB got confused. :-(

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 11 2017, 7:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits