Page MenuHomePhabricator

The keyboard shortcut for previewing a page (ctrl-option-p) doesn't do anything on some browsers
Closed, ResolvedPublic1 Story Points

Description

The keyboard shortcut ctrl-option-p is supposed to invoke page preview (in wikitext editors from 2010 and earlier).

On my Mac, within VisualEditor (both visual and wikitext modes), it just types π instead. @Sadads reports that the equivalent command invokes preview on his computer system (with catastrophic consequences: T153937: LOST WORK BUG: If you use the shortcut keyboard command to preview, you lose all your changes.).

This keyboard shortcut should either work everywhere (ideally sans catastrophic consequences, but that's the other bug) or nowhere.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 22 2016, 6:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DLynch added a subscriber: DLynch.Dec 22 2016, 11:07 PM

I can't reproduce this. Can you confirm that you're seeing the preview shortcut in the command help dialog? Also, which browser you're using?

Jdforrester-WMF triaged this task as High priority.Jan 3 2017, 8:30 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Per the help dialog, this is "^++P Show preview" which works for me in Chrome and Firefox, but is broken in Safari (surprise).

I am not seeing the preview shortcut in the command help dialog in Safari 10 or in Firefox 50.

TheDJ added a subscriber: TheDJ.Jan 3 2017, 9:07 PM

The shortcut for preview is not deployed to production yet maybe ? I see it (and it works) on https://en.wikipedia.beta.wmflabs.org/wiki/UserMergejfvvsc?veaction=editsource but not on production en.wp https://en.wikipedia.org/wiki/UserMergejfvvsc?veaction=editsource

DLynch added a comment.Jan 3 2017, 9:36 PM

@Jdforrester-WMF: It does work in Safari for me, just tested. Did you make a change to the document first? It behaves like the other save-related stuff and no-ops if you don't have any changes yet.

Jdforrester-WMF changed the task status from Open to Stalled.Jan 3 2017, 9:42 PM

Ah, hmm, yes, looks like I used the wrong shortcut. :-)

OK, now we're back to being bamboozled.

Elitre renamed this task from The keyboard shortcut for previewing a page (ctrl-option-p) doesn't do anything on a Mac to The keyboard shortcut for previewing a page (ctrl-option-p) doesn't do anything on some browsers.Sep 25 2017, 10:04 AM
Elitre added a subscriber: Elitre.

I changed the description as the relevant keyboard shortcut seems to be not working in FF Nightly as well.

Change 383410 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] init.mw.Target: make getSurfaceConfig aware of modes

https://gerrit.wikimedia.org/r/383410

Change 383410 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] init.mw.Target: make getSurfaceConfig aware of modes

https://gerrit.wikimedia.org/r/383410

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 11 2017, 7:32 PM