Page MenuHomePhabricator

Resultswitchers: process return before busting out of frames
Closed, ResolvedPublic4 Story Points

Description

For Ingenico and Adyen, we include their hosted checkout page in an iframe. They redirect the donor back to us in the iframe. We first serve the donor a page with javascript that breaks out of the frame and loads the same URL in the outer form, but with parameter liberated=1. Only on the second request do we actually process the donation and redirect donors to an error page or the thank you page.

We should tighten this up. When the iframe is redirected back to us, we should immediately process the donation (if we can show a spinner or the like while we work, so much the better!). Then when we decide whether to send the user to the thank you page or the error page, we should use the framebusting javascript to send them to that URL in the top frame.

Details

Related Gerrit Patches:
mediawiki/extensions/DonationInterface : deploymentprocess payment before popping out of iframe
mediawiki/extensions/DonationInterface : masterprocess payment before popping out of iframe
mediawiki/extensions/DonationInterface : masterWIP: Process payment before popping out of iframe

Event Timeline

Ejegg created this task.Dec 22 2016, 8:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2016, 8:29 PM
Ejegg assigned this task to cwdent.Dec 22 2016, 8:32 PM

Should be fine to do the spinner in a different patch - seems like it might be complicated to send a partial response, then the framebusting script later.

ggellerman triaged this task as High priority.Dec 22 2016, 8:55 PM
ggellerman moved this task from Backlog to Doing on the Fundraising Sprint Waiting for Godot board.

Change 328725 had a related patch set uploaded (by Cdentinger):
WIP: Process payment before popping out of iframe

https://gerrit.wikimedia.org/r/328725

Change 338410 had a related patch set uploaded (by Cdentinger):
process payment before popping out of iframe

https://gerrit.wikimedia.org/r/338410

Change 338410 merged by jenkins-bot:
process payment before popping out of iframe

https://gerrit.wikimedia.org/r/338410

Change 340371 had a related patch set uploaded (by Awight; owner: Cdentinger):
[mediawiki/extensions/DonationInterface] process payment before popping out of iframe

https://gerrit.wikimedia.org/r/340371

Change 340371 merged by jenkins-bot:
process payment before popping out of iframe

https://gerrit.wikimedia.org/r/340371

cwdent set the point value for this task to 4.
cwdent closed this task as Resolved.Mar 1 2017, 11:53 PM

Seems to be working!