Page MenuHomePhabricator

[minor-regression] Notification counter '99+' overlaps mw-echo-notifications-badge
Closed, ResolvedPublic

Assigned To
None
Authored By
Etonkovidova
Dec 22 2016, 8:52 PM
Tags
None
Referenced Files
F5302511: Screen Shot 2017-01-17 at 2.25.09 PM.png
Jan 17 2017, 10:25 PM
F5302506: Screen Shot 2017-01-17 at 2.20.18 PM.png
Jan 17 2017, 10:25 PM
F5302509: Screen Shot 2017-01-17 at 2.20.42 PM.png
Jan 17 2017, 10:25 PM
F5135371: Screen Shot 2016-12-22 at 12.31.01 PM.png
Dec 22 2016, 8:52 PM
F4346448: Screen Shot 2016-08-08 at 7.33.29 PM.png
Dec 22 2016, 8:52 PM
F5135369: Screen Shot 2016-12-21 at 5.14.35 PM.png
Dec 22 2016, 8:52 PM
F5135385: Screen Shot 2016-12-21 at 4.59.29 PM.png
Dec 22 2016, 8:52 PM
F4346447: Screen Shot 2016-08-08 at 7.33.48 PM.png
Dec 22 2016, 8:52 PM

Description

After the fix in T142454: Notices tray icon with 99+ needs more space the '99+' number of notifications icon overlaps the Alert and Notices icons more than before.

Before:

Screen Shot 2016-08-08 at 7.33.48 PM.png (100×650 px, 21 KB)

Screen Shot 2016-08-08 at 7.29.33 PM.png (120×829 px, 28 KB)

The monobook skin:

Screen Shot 2016-08-08 at 7.33.29 PM.png (56×698 px, 28 KB)

Now:

Screen Shot 2016-12-21 at 4.59.29 PM.png (102×798 px, 24 KB)

Screen Shot 2016-12-21 at 5.14.35 PM.png (155×1 px, 48 KB)

Screen Shot 2016-12-22 at 12.31.01 PM.png (304×1 px, 94 KB)

Event Timeline

I don't quite understand this ticket. The increased overlap of the counter over the icon is not a regression, it's the fix that had been decided for T142454.

The overlap that's problematic is when the counter is over the next element ("Talk" or otherwise) in the toolbar, which I don't see in these screenshots.

I think that I mixed up Before and Now when I was reporting it - sorry. Re-checked and closed the task as fixed. In 1.29.0-wmf.8 the placement of icons and text labels is satisfactory.

Screen Shot 2017-01-17 at 2.20.18 PM.png (90×426 px, 13 KB)

Screen Shot 2017-01-17 at 2.20.42 PM.png (81×393 px, 11 KB)

Screen Shot 2017-01-17 at 2.25.09 PM.png (87×409 px, 14 KB)

Etonkovidova triaged this task as Low priority.