Manage temporary readonly error
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Framawiki
	Dec 23 2016, 9:34 AM

Description

Meet with different scripts. PWB should retry after a minute.

WARNING: API error readonly: The database has been automatically locked while the slave database servers catch up to the master
Traceback (most recent call last):
...
 File "/mnt/nfs/labstore-secondary-tools-project/pywikibot/public_html/core/pywikibot/page.py", line 1235, in _save
    raise pywikibot.OtherPageSaveError(self, err)
pywikibot.exceptions.OtherPageSaveError: Edit to page [[Huang Bokai]] failed:
readonly: The database has been automatically locked while the slave database servers catch up to the master [readonlyreason:Waiting for 3 lagged database(s); help:See https://fr.wikipedia.org/w/api.php for $CRITICAL:  Closing network session.

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Manage temporary readonly error	pywikibot/core	master	+10 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Framawiki	T154011 Manage temporary readonly error
Duplicate	None	T164191 Tired of APIError: readonly
Duplicate	None	T154131 Touch.py should not crash on APIError: readonly
Duplicate	None	T160285 Manage temporary database lock error

Event Timeline

Framawiki created this task.Dec 23 2016, 9:34 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptDec 23 2016, 9:34 AM

Framawiki updated the task description. (Show Details)Dec 23 2016, 9:38 AM

zhuyifei1999 subscribed.Dec 23 2016, 11:02 AM

See T154131

zhuyifei1999 claimed this task.Dec 26 2016, 12:13 PM

zhuyifei1999 added a parent task: T154131: Touch.py should not crash on APIError: readonly.

Wait no.. the MediaWiki code for this is hard to deal with:

ApiMain::checkReadOnly calls both wfReadOnly and ApiMain::checkBotReadOnly
- wfReadOnly calls wfGetLB()->getReadOnlyReason()
  - The message given by LoadBalancer::getReadOnlyReason is hardcoded English
  - When it sees the wiki as read-only ApiBase::dieReadOnly is called, generating an api error with translatable apierror-readonly and the hardcoded The database has been automatically locked while the slave database servers catch up to the master as the readonlyreason
- Then ApiMain::checkBotReadOnly is called, and after some logic it generates an API error with translatable readonly_lag and another hardcoded English Waiting for $numLagged lagged database(s) as the readonlyreason

So two API errors seem to be generated, and both seem to lack some unique identifier.

Thanks @zhuyifei1999 for investigation.

On my error log above, I have the output WARNING: API error readonly: xxxxx, so that correspond to this.
It's look like the API error named internal_api_error_ReadOnlyError was renamed to readonly. So, in api.py, code.startswith(u'internal_api_error_') is not enabled (T61227).

I'll edit the code to accept readonly as an error that need edit retry

Change 333033 had a related patch set uploaded (by Gerrit Patch Uploader):
[bugfix] Menage temporary readonly error

https://gerrit.wikimedia.org/r/333033

gerritbot added a project: Patch-For-Review.Jan 19 2017, 6:10 PM

Framawiki merged a task: T154131: Touch.py should not crash on APIError: readonly.Jan 20 2017, 9:23 AM

Framawiki added a subscriber: JJMC89.

Framawiki updated the task description. (Show Details)Jan 20 2017, 9:25 AM

Framawiki mentioned this in T100123: API code 'readonly' not handled on Wikidata.Jan 20 2017, 9:29 AM

Alicia_Fagerving_WMSE mentioned this in T160285: Manage temporary database lock error.Mar 12 2017, 6:33 PM

zhuyifei1999 mentioned this in T164191: Tired of APIError: readonly.May 2 2017, 2:45 PM

MarcoAurelio subscribed.May 2 2017, 3:04 PM

Framawiki renamed this task from Menage temporary readonly error to Manage temporary readonly error.May 10 2017, 7:22 AM