Page MenuHomePhabricator

Problem with marking mention notifications as read when visiting the originating page
Open, Stalled, Needs TriagePublic

Description

Not sure if this is the same issue or two separate issues, feel free to split this up.

I posted a new section in Template_talk namespace in hewiki. Then, I got a notification for a mention. I went to the page directly (it was actually already open, so I just refreshed it) and answered; a few minutes later, I received another notification for a mention for the same page, and did the same (refresh + answer)

At no point did I click the notifications themselves, but I did go to the page that they link to. I believe this should mark them as read?

Second issue - both of those notifications, received a few minutes apart, are displayed separately and not bundled. Shouldn't they be bundled, either in a single bundle-notification or in an expandable bundle? The text of the notification is exactly the same, the only difference is the excerpt at the bottom. See screenshot:

Event Timeline

Mooeypoo created this task.Dec 23 2016, 9:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2016, 9:53 PM
SBisson added a subscriber: SBisson.Jan 3 2017, 2:53 PM

'mention' notifications do not generate target-page entries, which are required for the mark-as-read-on-visit feature to work. It does not look like it was changed recently so it may have been like that for a long time or even forever.

I think it's reasonnable to expect this feature to work for mentions and it's a small change.

'mention' notifications do not generate target-page entries, which are required for the mark-as-read-on-visit feature to work. It does not look like it was changed recently so it may have been like that for a long time or even forever.
I think it's reasonnable to expect this feature to work for mentions and it's a small change.

I agree about changing this.

Also, I think there's actually another bug here -- even if the mark-as-read doesn't work, shouldn't we *bundle* those notifications? Getting two that look the same (even if I didn't actually read the first, so regardless of marking as read) is weird.

Should we / can we change that too?

Also, I think there's actually another bug here -- even if the mark-as-read doesn't work, shouldn't we *bundle* those notifications? Getting two that look the same (even if I didn't actually read the first, so regardless of marking as read) is weird.
Should we / can we change that too?

I don't know if it's a bug or a new feature but bundling is a bit more involved as it requires thinking about bundling rules, links, messages, etc. I would propose creating a different ticket for it and keeping the current ticket for mark-as-read-on-visit.

Change 333265 had a related patch set uploaded (by Sbisson):
Auto mark-as-read mentions

https://gerrit.wikimedia.org/r/333265

Hmm, I'm not sure if this is a good feature or a bad one. For large or not-easily-understandable discussion pages (like village pumps for instance) or discussion pages where you're participating in two threads at the same time, I could see this resulting in "lost" mention notifications quite easily.

@jmatazzoni: Thoughts?

SBisson changed the task status from Open to Stalled.Aug 1 2017, 1:06 PM

Change 333265 abandoned by Sbisson:
Auto mark-as-read mentions

Reason:
We can restore this patch if/when a decision is made in the ticket.

https://gerrit.wikimedia.org/r/333265

I re-checked the issue

  • a user is on the page
  • the page will be updated with multiple mentions about the user
  • the user updates the page and sees the Alerts badge becomes red and the count changes indicating that new mentions come.

    I agree with @Catrope - even if a user is currently on a page that mentions were posted, it's good to have an additional signaling about mentions. Regarding bundling, there is the separate ticket T155531: Consider bundling mention notifications from the same context.

I'll leave to @jmatazzoni to make a decision whether we should proceed with the above patch or not.

Not sure I understand the issue fully. I tried to reproduce on beta by making multiple mentions of myself, but got no notifications at all. What am I doing wrong (below)?

@jmatazzoni - mentions of yourself do not send notifications