'mention' notifications do not generate target-page entries, which are required for the mark-as-read-on-visit feature to work. It does not look like it was changed recently so it may have been like that for a long time or even forever.

I think it's reasonnable to expect this feature to work for mentions and it's a small change.

In T154057#2912791, @SBisson wrote:

'mention' notifications do not generate target-page entries, which are required for the mark-as-read-on-visit feature to work. It does not look like it was changed recently so it may have been like that for a long time or even forever.

I think it's reasonnable to expect this feature to work for mentions and it's a small change.

I agree about changing this.

Also, I think there's actually another bug here -- even if the mark-as-read doesn't work, shouldn't we *bundle* those notifications? Getting two that look the same (even if I didn't actually read the first, so regardless of marking as read) is weird.

Should we / can we change that too?

In T154057#2945916, @Mooeypoo wrote:

Also, I think there's actually another bug here -- even if the mark-as-read doesn't work, shouldn't we *bundle* those notifications? Getting two that look the same (even if I didn't actually read the first, so regardless of marking as read) is weird.

Should we / can we change that too?

I don't know if it's a bug or a new feature but bundling is a bit more involved as it requires thinking about bundling rules, links, messages, etc. I would propose creating a different ticket for it and keeping the current ticket for mark-as-read-on-visit.

Done: T155531: Consider bundling mention notifications from the same context

Change 333265 had a related patch set uploaded (by Sbisson):
Auto mark-as-read mentions

https://gerrit.wikimedia.org/r/333265

Hmm, I'm not sure if this is a good feature or a bad one. For large or not-easily-understandable discussion pages (like village pumps for instance) or discussion pages where you're participating in two threads at the same time, I could see this resulting in "lost" mention notifications quite easily.

@jmatazzoni: Thoughts?

Change 333265 abandoned by Sbisson:
Auto mark-as-read mentions

Reason:
We can restore this patch if/when a decision is made in the ticket.

https://gerrit.wikimedia.org/r/333265

I re-checked the issue

• a user is on the page
• the page will be updated with multiple mentions about the user
• the user updates the page and sees the Alerts badge becomes red and the count changes indicating that new mentions come.
  
  I agree with @Catrope - even if a user is currently on a page that mentions were posted, it's good to have an additional signaling about mentions. Regarding bundling, there is the separate ticket T155531: Consider bundling mention notifications from the same context.

I'll leave to @jmatazzoni to make a decision whether we should proceed with the above patch or not.

Not sure I understand the issue fully. I tried to reproduce on beta by making multiple mentions of myself, but got no notifications at all. What am I doing wrong (below)?

@jmatazzoni - mentions of yourself do not send notifications