Page MenuHomePhabricator

LifeWeb extension missing API messages
Closed, ResolvedPublic

Description

The LifeWeb extension is using old API message formats, these should be replaced with i18n messages with entries in the files en.json and qqq.json.

See https://www.mediawiki.org/wiki/API:Localisation for more information. Looking at many other extensions will also provide working examples. Such as https://github.com/wikimedia/mediawiki-extensions-CodeReview/blob/master/api/ApiCodeDiff.php#L73-L95 along with https://github.com/wikimedia/mediawiki-extensions-CodeReview/blob/master/i18n/en.json#L192-L195 and https://github.com/wikimedia/mediawiki-extensions-CodeReview/blob/master/i18n/qqq.json#L218-L221

19:43:31 1) ApiDocumentationTest::testDocumentationExists with data set "Module query+LifeWeb with MiserMode=false, AllowCategorizedRecentChanges=false" ('query+LifeWeb', array(false, false))
19:43:31 Module description message apihelp-query+LifeWeb-description exists
19:43:31 Failed asserting that false is true.
19:43:31 
19:43:31 /srv/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/structure/ApiDocumentationTest.php:51
19:43:31 /srv/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/structure/ApiDocumentationTest.php:80
19:43:31 /srv/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/MediaWikiTestCase.php:399
19:43:31 /srv/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/maintenance/doMaintenance.php:111
19:43:31 
19:43:31 2) ApiDocumentationTest::testDocumentationExists with data set "Module query+LifeWeb with MiserMode=true, AllowCategorizedRecentChanges=true" ('query+LifeWeb', array(true, true))
19:43:31 Module description message apihelp-query+LifeWeb-description exists
19:43:31 Failed asserting that false is true.
19:43:31 
19:43:31 /srv/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/structure/ApiDocumentationTest.php:51
19:43:31 /srv/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/structure/ApiDocumentationTest.php:80
19:43:31 /srv/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/tests/phpunit/MediaWikiTestCase.php:399
19:43:31 /srv/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/maintenance/doMaintenance.php:111

Details

Related Gerrit Patches:
mediawiki/extensions/LifeWeb : masterAdd missing API i18n messages

Event Timeline

Reedy created this task.Dec 24 2016, 9:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 24 2016, 9:24 PM

Change 329222 had a related patch set uploaded (by MtDu):
Add missing API i18n messages

https://gerrit.wikimedia.org/r/329222

Change 329222 merged by jenkins-bot:
Add missing API i18n messages

https://gerrit.wikimedia.org/r/329222

MtDu closed this task as Resolved.Dec 27 2016, 12:20 AM
MtDu claimed this task.
MtDu added a subscriber: MtDu.

Patch has been merged. Hence closing as resolved.