Page MenuHomePhabricator

AkismetKlik cleanup
Closed, ResolvedPublic

Description

  • Use autoloader, rather than just require PHP file (add all classes/interfaces as appropriate)
  • Check if wfAkismetKlikObject() is properly unused, if so, remove
  • Move hook functions out of Global Scope (part of task below)
  • Convert to extension registration T98668

Event Timeline

Reedy renamed this task from AkismetKlick cleanup to AkismetKlik cleanup.Dec 25 2016, 11:21 AM

Change 329242 had a related patch set uploaded (by Georggi199):
Converted AkismetKlik extension to new registration system

https://gerrit.wikimedia.org/r/329242

@Reedy: @Georggi1999 Hmm, should we keep backward compatibility? Now, AkismentKlik supports 1.19+ so we shouldn't remove this AkismentKlik.php code. Just keep it, and add extension registration. But in case we don't want to keep backward compatibility, we should remove all of these old registration code.

Most extension master versions don't need to support all MW versions; that's why we branch extensions when we branch MW core, to try and keep them compatible

Change 329242 merged by jenkins-bot:
AkismetKlik extension cleanup

https://gerrit.wikimedia.org/r/329242

MtDu assigned this task to Georggi199.
MtDu added a subscriber: MtDu.

Patch has been merged, hence closing as resolved. Thanks!