Page MenuHomePhabricator
Create Task
Maniphest T154122

Minification and bundling for wikilabels assets
Closed, ResolvedPublic
Actions

Description

Wikilabels assets are super big and should be compressed and minified.

We have several options:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikilabels: install nodejs packageoperations/puppetproduction+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Dec 25 2016, 11:27 PM
Halfak added a comment.Dec 26 2016, 5:52 PM

See https://github.com/wiki-ai/wikilabels/blob/master/wikilabels/wsgi/routes/gadget.py#L74

Ladsgroup added a comment.Dec 27 2016, 2:59 AM

minify doesn't work :/ http://labels.wmflabs.org/gadget/WikiLabels.js?minify=1

Ladsgroup added a comment.Dec 27 2016, 3:01 AM

Strangely it works in my localhost. :)))

Ladsgroup added a comment.Dec 27 2016, 3:06 AM

From logs of wikilabels-experiment:

Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: 2016-12-27 03:03:05,504 ERROR:wikilabels -- Exception on /gadget/WikiLabels.js [GET]
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: Traceback (most recent call last):
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/flask/app.py", line 1817, in wsgi_app
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: response = self.full_dispatch_request()
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/flask/app.py", line 1477, in full_dispatch_request
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: rv = self.handle_user_exception(e)
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/flask/app.py", line 1381, in handle_user_exception
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: reraise(exc_type, exc_value, tb)
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: raise value
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/flask/app.py", line 1475, in full_dispatch_request
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: rv = self.dispatch_request()
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/flask/app.py", line 1461, in dispatch_request
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: return self.view_functions[rule.endpoint](**req.view_args)
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "./wikilabels/wsgi/routes/gadget.py", line 74, in gadget_application
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: response_text = minify_js(response_text)
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "./wikilabels/wsgi/util.py", line 76, in minify_js
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: return uglipyjs.compile(js_text)
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/uglipyjs/__init__.py", line 203, in compile
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: instance = UglipyJS(options or {})
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/uglipyjs/__init__.py", line 49, in __init__
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: self._context = execjs.compile(io.open(UglipyJS.es5_fallback_path, "r",encoding=self._options['encoding']).read() + io.open(UglipyJS.source_path, "r",encoding=self._options['encoding']).read())
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/execjs/__init__.py", line 134, in compile
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: return get().compile(source)
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/execjs/__init__.py", line 74, in get
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: return _auto_detect()
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: File "/srv/wikilabels/venv/lib/python3.4/site-packages/execjs/__init__.py", line 106, in _auto_detect
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: raise RuntimeUnavailable("Could not find a JavaScript runtime.")
Dec 27 03:03:05 wikilabels-experiment uwsgi-wikilabels-web[18598]: execjs.RuntimeUnavailable: Could not find a JavaScript runtime.
Ladsgroup added a comment.Dec 27 2016, 3:08 AM

Fixed by installing nodejs \o/

Stashbot subscribed.Dec 27 2016, 3:09 AM

Mentioned in SAL (#wikimedia-labs) [2016-12-27T03:09:08Z] <Amir1> installing nodejs in wikilabels nodes (T154122)

gerritbot subscribed.Dec 27 2016, 3:12 AM

Change 329316 had a related patch set uploaded (by Ladsgroup):
wikilabels: install nodejs package

https://gerrit.wikimedia.org/r/329316

gerritbot added a project: Patch-For-Review.Dec 27 2016, 3:12 AM
Ladsgroup added a comment.Dec 27 2016, 3:43 AM

I started https://github.com/wiki-ai/wikilabels/pull/143

Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 2 2017, 9:03 AM
Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Jan 2 2017, 10:09 AM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.
gerritbot added a comment.Jan 3 2017, 4:58 PM

Change 329316 merged by Giuseppe Lavagetto:
wikilabels: install nodejs package

https://gerrit.wikimedia.org/r/329316

Halfak renamed this task from Minification and gzip compression for wikilabels assets to Minification and bundling for wikilabels assets.Jan 4 2017, 10:55 PM
Halfak moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.
Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.Jan 5 2017, 10:50 AM
Halfak closed this task as Resolved.Feb 7 2017, 8:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits