Page MenuHomePhabricator

RandomUsersWithAvatars should allow the user to specify avatar image size
Closed, ResolvedPublic

Description

Currently RandomUsersWithAvatars allows the end-user to control how many avatars are shown in total and how many are shown per row, but it doesn't allow to control the avatar size -- all avatars rendered by RandomUsersWithAvatars are medium-large (ml; 50x50px). Sometimes you might want large avatars, or medium avatars or even small avatars (okay, maybe not, the small ones are just too small for my liking, but who knows what some reuser somewhere might want to do with the extension...). Let's give the user the control over the avatar size, too.

Event Timeline

Change 329200 had a related patch set uploaded (by SamanthaNguyen):
Allow users to specify avatar image size

https://gerrit.wikimedia.org/r/329200

Change 329200 merged by jenkins-bot:
Allow users to specify avatar image size

https://gerrit.wikimedia.org/r/329200

I did some fixes after the aforementioned patch, this patchset and another one. Turns out that, unlike I thought, surprisingly many places assumed and hard-coded in medium-large avatars -- even the CSS (!). Everything should now be in order, save for the fact that avatar stuff (in SocialProfile) is heavily cached, so it may take up to a day for the changes to show up on the testing site.

Thanks again for all your hard work, @SamanthaNguyen!

Ah okay, sounds good! Also no problem - thanks for helping me with the patch! :)