Page MenuHomePhabricator
Create Task
Maniphest T154256

the language-switcher on SVG file isn't working
Closed, DuplicatePublic
Actions

Description

This SVG file have the systemLanguage text

图片.png (716×265 px, 14 KB)

I switch the lanuguage and submit the request. Then It only return the rendering of the en language. And it seems that it will fallback to the first language of text tag which the tag is en at frist.
T125710
It seems a lot of problem. Is it about that?

Related Objects

Event Timeline

Cwek created this task.Dec 29 2016, 1:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2016, 1:11 AM
Glrx subscribed.Dec 29 2016, 1:42 AM

Problem 1 (Language switching at ImagePage.php) is improper handling of URL lang arg on Commons File pages. Selecting a language with mixed case langtag will fail. Same problem as T154132.

Problem 2 (switch processing at svg-cond.c) is librsvg not handling langtags according to the SVG specification. It will prefix match to the first hyphen. Same problem as T125710 and T154237.

Cwek added a comment.Dec 30 2016, 12:30 AM
In T154256#2905644, @Glrx wrote:

Problem 1 (Language switching at ImagePage.php) is improper handling of URL lang arg on Commons File pages. Selecting a language with mixed case langtag will fail. Same problem as T154132.

Problem 2 (switch processing at svg-cond.c) is librsvg not handling langtags according to the SVG specification. It will prefix match to the first hyphen. Same problem as T125710 and T154237.

It seems that it like T154132. I suggest it use another parameter name for switching the language of svg view page because it seems that the 'lang' parameter have been used by ULS.

Aklapper closed this task as a duplicate of T154132: SVG image files, switch systemLanguage, lang argument, and mixed-case IETF langtags.Dec 30 2016, 12:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits