simple form without "for template" results in PHP Notice
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MarkAHershberger
	Dec 29 2016, 1:26 AM

Description

This simple form:

{{{field|job type|input type=checkboxes|values from property=Job Types}}}

results in the following notice whenever the form is used:

Notice: Undefined variable: template_name in wiki/extensions/PageForms/includes/PF_FormPrinter.php on line 1119

Patch incoming

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix E_NOTICE	mediawiki/extensions/PageForms	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: rEPFM1e9a282c7ce0: Fix E_NOTICE

Event Timeline

MarkAHershberger created this task.Dec 29 2016, 1:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2016, 1:26 AM

MarkAHershberger renamed this task from simple form without "results in PHP Notice to simple form without "for template" results in PHP Notice.Dec 29 2016, 1:34 AM

MarkAHershberger claimed this task.

MarkAHershberger added a project: MediaWiki-extensions-Page_Forms.

MarkAHershberger updated the task description. (Show Details)

Change 329538 had a related patch set uploaded (by MarkAHershberger):
Fix E_NOTICE

https://gerrit.wikimedia.org/r/329538

gerritbot added a project: Patch-For-Review.Dec 29 2016, 1:46 AM

MarkAHershberger mentioned this in rEPFM1e9a282c7ce0: Fix E_NOTICE.Dec 29 2016, 1:46 AM

Change 329538 merged by Yaron Koren:
Fix E_NOTICE

https://gerrit.wikimedia.org/r/329538

I merged in the patch, although I don't see why you would have an "input" tag without a "for template" tag - that looks like an error.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 29 2016, 3:00 AM

In T154257#2905708, @Yaron_Koren wrote:

I merged in the patch, although I don't see why you would have an "input" tag without a "for template" tag - that looks like an error.

I agree, but we shouldn't depend upon PHP E_NOTICE to report those problems.

Fixed a while ago, I guess.

simple form without "for template" results in PHP NoticeClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

simple form without "for template" results in PHP Notice
Closed, ResolvedPublic
Actions