Page MenuHomePhabricator

simple form without "for template" results in PHP Notice
Closed, ResolvedPublic

Description

This simple form:

{{{field|job type|input type=checkboxes|values from property=Job Types}}}

results in the following notice whenever the form is used:

Notice: Undefined variable: template_name in wiki/extensions/PageForms/includes/PF_FormPrinter.php on line 1119

Patch incoming

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2016, 1:26 AM
MarkAHershberger renamed this task from simple form without "results in PHP Notice to simple form without "for template" results in PHP Notice.Dec 29 2016, 1:34 AM
MarkAHershberger claimed this task.
MarkAHershberger updated the task description. (Show Details)

Change 329538 had a related patch set uploaded (by MarkAHershberger):
Fix E_NOTICE

https://gerrit.wikimedia.org/r/329538

Change 329538 merged by Yaron Koren:
Fix E_NOTICE

https://gerrit.wikimedia.org/r/329538

I merged in the patch, although I don't see why you would have an "input" tag without a "for template" tag - that looks like an error.

I merged in the patch, although I don't see why you would have an "input" tag without a "for template" tag - that looks like an error.

I agree, but we shouldn't depend upon PHP E_NOTICE to report those problems.

Yaron_Koren closed this task as Resolved.Feb 28 2017, 2:58 PM

Fixed a while ago, I guess.