Page MenuHomePhabricator

Deprecate ArticleRollbackComplete hook
Closed, InvalidPublic

Description

Rollbacks shouldn't be treated differently by extensions from other multiple-revisions undoes.
They can use the PageContentSaveComplete hook, provided we pass the current rev id as undid rev id.

Event Timeline

Hi @Cenarium. Please associate at least one project with this task to allow others to find this task when searching in the corresponding project(s). Is this task about MediaWiki core? Or something else? Thanks!

Change 329651 had a related patch set uploaded (by Cen.temp):
Add wpBaseRevision to edit request from 'undoafter' param

https://gerrit.wikimedia.org/r/329651

Change 330587 had a related patch set uploaded (by Cen.temp):
Notify users of multiple-revisions undos

https://gerrit.wikimedia.org/r/330587

Change 330625 had a related patch set uploaded (by Cen.temp):
Increment all reverts in PageContentSaveComplete hook

https://gerrit.wikimedia.org/r/330625

Ostrzyciel subscribed.

This hook was deprecated and replaced with RollbackComplete in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/589823

Anyway, the point presented in this task's description is still valid, so I'll be making a related task for the new hook.

Change #330625 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/FlaggedRevs@master] Increment all reverts in PageContentSaveComplete hook

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/1015176

https://gerrit.wikimedia.org/r/330625