Page MenuHomePhabricator

Special:NewLexeme should use distinct field IDs for lexeme language and lemma language.
Closed, ResolvedPublic

Description

In SpecialNewLexeme, we need to make sure there is no confusion between the lemma language. In particular, the labels, names, and ids of the form fields need to be distinct and easily recognizable. I suggest to use "lexeme-language-item" and "lemma-language-code".

Note that the form field for the lemma language may no longer be needed once T154316: Special:NewLexeme should use derive lemma language from lexeme language. is implemented.

Event Timeline

daniel created this task.Dec 30 2016, 11:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 30 2016, 11:47 AM
daniel assigned this task to Ladsgroup.Dec 30 2016, 11:48 AM
daniel triaged this task as High priority.

Setting to high prio, since this we are currently generating invalid HTML (using non-unique element IDs).

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 30 2016, 11:48 AM

I'm working on it.

Change 330113 had a related patch set uploaded (by Ladsgroup):
Clean up IDs in SpecialNewLexeme

https://gerrit.wikimedia.org/r/330113

Just curious, where can I view the test version of Wiktionary features?

@Esc3300 we don't have a public test system set up yet. We'll keep you informed!

Change 330113 merged by jenkins-bot:
Clean up IDs in SpecialNewLexeme

https://gerrit.wikimedia.org/r/330113

Change 330213 had a related patch set uploaded (by Ladsgroup):
Inject dependencies to SpecialPagesWithBadges

https://gerrit.wikimedia.org/r/330213

Oops wrong phab card

thiemowmde closed this task as Resolved.Jan 3 2017, 1:27 PM