The sse client that kafka-sse is using does not allow us to override the Content-Type header and set charset. This causes libraries like Python Requests to break, since they properly default to using ISO-8859-1 (Latin-1) instead of utf-8 when decoding the response body if no charset is provided.
We need to either upstream a patch to our sse client, or fork it and use our own.
| Restricted Differential Revision |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | Xqt | T125197 Give hint to the current socketIO_client in ImportError of rcstream.py | |||
| Declined | None | T91393 RCStream is not accessible from python client due to using socket-io 1.0 while only socket-io 0.9 is offered | |||
| Declined | None | T68232 Upgrade RCStream backend to use socket.io 1.0 protocol | |||
| Resolved | Ottomata | T130651 EventStreams | |||
| Resolved | mforns | T154328 Set charset=utf-8 in Content-Type response header from sse.js client |
Pull request created: https://github.com/einaros/sse.js/pull/22
We'll see if there is any response.
Change 330535 had a related patch set uploaded (by Ottomata):
Bump kafka-sse version to 0.0.6 to include charset / SSEResponse fix
Change 330535 merged by Ottomata:
Bump kafka-sse version to 0.0.6 to include charset / SSEResponse fix
I don't know how to make the revision appear in this view...
Anyway, above is the link to the revision with the changes.