Page MenuHomePhabricator
Create Task
Maniphest T154330

Improve illustration on pagepreview disable screen and make it RTL compatible
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
• Nirzar
Authored By
Amire80
Dec 30 2016, 6:14 PM
Tags
Referenced Files
F5598305: RTL.png
Feb 10 2017, 10:20 PM
F5598306: LTR.png
Feb 10 2017, 10:20 PM
F5597965: pasted_file
Feb 10 2017, 10:20 PM
F5194257: Wikipédia a szabad enciklopédia.png
Dec 30 2016, 6:14 PM
Subscribers
ABorbaWMF
Aklapper
Amire80
• bmansurov
gerritbot
• Nirzar
ovasileva
phuedx

Description

Problem

The illustration after a user disables pagepreviews, which is supposed to indicate the position of "enable page preview" link in the footer is bad. very bad. it is also not RTL compatible

pasted_file (698×996 px, 69 KB)

Solution

Improve it and provide RTL version

RTL.png (1×2 px, 684 KB)

LTR.png (1×2 px, 690 KB)

Zeplin
LTR: https://zpl.io/ZBunrg
RTL: https://zpl.io/10P7uP

QA Steps

  1. Visit http://reading-web-staging.wmflabs.org/wiki/Test.
  2. Log out (if necessary).
  3. Dwell on the "Lead section image" link until a preview appears.
  4. Click the settings cog.
  5. Disable PP.
  6. Observe the new illustration.

Repeat the same steps when viewing an RTL interface language, e.g. http://reading-web-staging.wmflabs.org/wiki/Test?uselang=he

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Improve illustration on disable popupmediawiki/extensions/Popupsmaster+16 -52
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Dec 30 2016, 6:14 PM
Restricted Application added a project: I18n. · View Herald TranscriptDec 30 2016, 6:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 updated the task description. (Show Details)Dec 30 2016, 6:14 PM
phuedx triaged this task as High priority.Jan 5 2017, 10:33 AM
phuedx added a project: Web-Team-Backlog-Archived.
phuedx set the point value for this task to 1.
phuedx moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.
ovasileva moved this task from Backlog to For Review on the Page-Previews board.Feb 2 2017, 3:42 PM
ovasileva moved this task from For Review to 2016-17-Q3-Goal on the Page-Previews board.
ovasileva edited projects, added Page-Previews (2016-17-Q3-Goal); removed Page-Previews.
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog-Archived board.
ovasileva added subscribers: • Nirzar, ovasileva.

@Nirzar - what should behavior be here?

ovasileva added a project: Reading-Web-Sprint-92-🍜.Feb 9 2017, 2:03 PM
• Nirzar claimed this task.Feb 9 2017, 7:02 PM
• Nirzar renamed this task from flip the disabling explanation image for Hovercards in RTL languages to Improve illustration on pagepreview disable screen and make it RTL compatible .Feb 10 2017, 10:20 PM
• Nirzar updated the task description. (Show Details)
• Nirzar removed the point value 1 for this task.

@ovasileva updated description. we can reprioritize and reestimate

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-92-🍜 board.Feb 15 2017, 6:32 PM
ovasileva set the point value for this task to 2.Feb 15 2017, 6:32 PM
ovasileva changed the point value for this task from 2 to 3.
ovasileva moved this task from Backlog to Doing on the Page-Previews (2016-17-Q3-Goal) board.Feb 16 2017, 6:30 PM
ovasileva moved this task from Upcoming to 2016-17 Q3 on the Web-Team-Backlog-Archived board.Feb 17 2017, 12:04 PM
• Nirzar removed • Nirzar as the assignee of this task.Feb 23 2017, 9:49 PM
ovasileva added a project: Reading-Web-Sprint-94.Mar 1 2017, 12:18 PM
ovasileva moved this task from 2016-17 Q3 to Upcoming on the Web-Team-Backlog-Archived board.Mar 2 2017, 4:30 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-94 board.Mar 8 2017, 5:32 PM
ovasileva moved this task from To Do to Needs Analysis on the Reading-Web-Sprint-94 board.Mar 15 2017, 5:18 PM
MBinder_WMF removed a project: Reading-Web-Sprint-94.Mar 15 2017, 5:57 PM
MBinder_WMF moved this task from Upcoming to Design on the Web-Team-Backlog-Archived board.Mar 21 2017, 4:45 PM
MBinder_WMF edited projects, added Web-Team-Backlog-Archived (Design); removed Web-Team-Backlog-Archived.
phuedx subscribed.Mar 21 2017, 4:45 PM

@Nirzar: Could you upload the LTR and RTL versions of the image in your designs to Zeplin?

ovasileva added a comment.Apr 11 2017, 8:28 AM

@Nirzar - wasn't there another task for this? I can't seem to find it

ovasileva mentioned this in T162162: Deploy page previews to Hungarian and Hebrew wikipedias.Apr 11 2017, 8:31 AM
phuedx added a comment.Apr 11 2017, 5:16 PM
In T154330#3170615, @ovasileva wrote:

@Nirzar - wasn't there another task for this? I can't seem to find it

This is that task! See T154330#3018450.

ovasileva moved this task from Design to Upcoming on the Web-Team-Backlog-Archived board.Apr 13 2017, 11:42 AM
ovasileva edited projects, added Web-Team-Backlog-Archived; removed Web-Team-Backlog-Archived (Design).
ovasileva added a project: Reading-Web-Sprint-96.Apr 13 2017, 6:50 PM
ovasileva moved this task from 2016-17-Q3-Goal to Next Up on the Page-Previews board.Apr 13 2017, 7:19 PM
ovasileva edited projects, added Page-Previews; removed Page-Previews (2016-17-Q3-Goal).
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-96 board.Apr 19 2017, 5:25 PM
Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog-Archived board.Apr 19 2017, 6:38 PM
• bmansurov subscribed.Apr 21 2017, 2:29 PM

@Nirzar I understand that the proposed solution solves the problem with RTL languages, however does it solve the following:

... is bad. very bad. ...

I'm not sure what's bad about it. A clarification would help implement the right solution. /cc @Amire80

• bmansurov claimed this task.Apr 21 2017, 2:29 PM
• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-96 board.
• Nirzar added a comment.Apr 21 2017, 6:14 PM

sure.

Why is the current illustration bad.

Too minimalistic - the current illustration removes all point of references around where these links are. The primary purpose of illustration is to show the position of footer links. We need to show the position in relation with the entire page. aka at the bottom of the page.

gerritbot subscribed.Apr 21 2017, 7:42 PM

Change 349535 had a related patch set uploaded (by Bmansurov):
[mediawiki/extensions/Popups@master] Improve illustration on disable popup

https://gerrit.wikimedia.org/r/349535

gerritbot added a project: Patch-For-Review.Apr 21 2017, 7:42 PM
• bmansurov moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-96 board.Apr 21 2017, 7:42 PM
• bmansurov added a comment.Apr 21 2017, 7:56 PM

@Nirzar you can test the above patch at http://reading-web-staging.wmflabs.org/w/index.php?title=Test by hovering over "lead section image". Make sure you're logged out.

• Nirzar added a comment.Apr 21 2017, 8:16 PM

Macro votecat: design approves

Amire80 added a comment.Apr 22 2017, 8:02 AM

Ow. I'm not sure why does the bug description say "bad. very bad". I only meant to say that it's confusing with regards to RTL.

phuedx added a comment.Apr 24 2017, 5:08 PM

I've +1'd rEPOP1b818610d5c6: Improve illustration on disable popup and I'm testing it locally now.

gerritbot added a comment.Apr 24 2017, 6:45 PM

Change 349535 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Improve illustration on disable popup

https://gerrit.wikimedia.org/r/349535

phuedx reassigned this task from • bmansurov to ABorbaWMF.Apr 24 2017, 6:51 PM
phuedx updated the task description. (Show Details)
phuedx moved this task from Needs Code Review to Needs QA on the Reading-Web-Sprint-96 board.
• Nirzar added a comment.Apr 24 2017, 6:54 PM

Ow. I'm not sure why does the bug description say "bad. very bad". I only meant to say that it's confusing with regards to RTL.

That was me. I wrote that. :)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 24 2017, 7:00 PM
ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-96 board.Apr 25 2017, 9:09 PM

Tested on http://reading-web-staging.wmflabs.org/wiki/Test?uselang=he

Tried on Chrome, Firefox, IE/Edge, and Opera browsers on a variety of Mac and Windows OS devices. Appears to be fixed.

phuedx reassigned this task from ABorbaWMF to • Nirzar.EditedApr 26 2017, 10:34 AM
phuedx added a subscriber: ABorbaWMF.

@Nirzar: I know you've looked at this on the staging server before but that was with a specific commit checked out. I've updated the staging server to the tip of the master branch (to be deployed next Thursday, 4th May). Could you have another gander at it?

• Nirzar added a comment.Apr 26 2017, 7:43 PM

@phuedx checked again on HE. looks good!

phuedx closed this task as Resolved.Apr 26 2017, 9:13 PM

I'll be the signer offerer for PP tasks (that I haven't submitted changes for) while @ovasileva is OOO.

Per T154330#3215369, this is 👍

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits