Page MenuHomePhabricator

History popstate not always handled (back broken) on Special:ExtensionDistributor
Open, Needs TriagePublic

Description

  1. Select an extension
  2. Reload the page (now Special:ExtensionDistributor/ExtensionName)
  3. Hit back

Nothing happens because after 2 we assume you are in no-JS mode, so don't handle the pop state.

Event Timeline

Legoktm renamed this task from History popstate not always handled (back broken) to History popstate not always handled (back broken) on Special:ExtensionDistributor.Feb 1 2017, 8:05 AM

Change 471329 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/ExtensionDistributor@master] Fix history pop-state on Special:ExtensionDistributor

https://gerrit.wikimedia.org/r/471329

xSavitar added a subscriber: xSavitar.

With or without step 2, once extension is selected and back is pressed, nothing happens. So I've dropped a patch that simply reloads the page (Special:ExtensionDistributor) when back is pressed. Still need to figure out how to deal with this in no-JS mode.

@D3r1ck01 Good find. Yeah, going back to the initial state isn't supported in either mode currently.

However, there is code for onpopstate handling, and it does work. What does currently is for switching between extensions:

  1. Select an extension.
  2. Select a different one.
  3. Press back.

Change 471329 abandoned by D3r1ck01:
Fix history pop-state on Special:ExtensionDistributor

Reason:
No longer working on this. Someone interested can resurrect.

https://gerrit.wikimedia.org/r/471329