Page MenuHomePhabricator
Create Task
Maniphest T154447

Move "wikibase_item" search field definition and indexing from CirrusSearch to Wikibase
Closed, ResolvedPublic
Actions

Description

CirrusSearch currently adds a "wikibase_item" field to the search index, which indexes the associated Wikibase item ID for a given page in Wikibase client wikis.

The field should be moved to Wikibase and use the new hooks available in core.

Details

SubjectRepoBranchLines +/-
Remove wikibase_item from Cirrus codebasemediawiki/extensions/CirrusSearchmaster+2 -39
Make Wikibase Client create wikibase_item fieldmediawiki/extensions/Wikibasemaster+177 -0
Expose Cirrus factory for extensions to be able to build fields.mediawiki/extensions/CirrusSearchmaster+16 -0
Customize query in gerrit

Event Timeline

aude created this task.Jan 2 2017, 9:29 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptJan 2 2017, 9:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
aude claimed this task.Jan 25 2017, 3:05 AM
• Deskana removed a project: Discovery-Search.Apr 20 2017, 5:22 PM
Addshore removed aude as the assignee of this task.Sep 18 2018, 12:48 PM
Addshore added a project: [DEPRECATED] wdwb-tech.
Addshore added subscribers: Smalyshev, Addshore.

Discovery-ARCHIVED & @Smalyshev etc. Is this still an issue?

Addshore moved this task from Inbox to Investigate & Discuss on the [DEPRECATED] wdwb-tech board.Sep 18 2018, 12:48 PM
Smalyshev added a project: User-Smalyshev.Sep 18 2018, 5:50 PM

Looks like it's still in Cirrus. Probably a good idea to move, I forgot about this one.

Smalyshev triaged this task as Medium priority.Sep 18 2018, 10:39 PM
Smalyshev moved this task from Backlog to Next on the User-Smalyshev board.
gerritbot subscribed.Oct 3 2018, 11:18 PM

Change 464458 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/CirrusSearch@master] Expose Cirrus factory for extensions to be able to build fields.

https://gerrit.wikimedia.org/r/464458

gerritbot added a project: Patch-For-Review.Oct 3 2018, 11:18 PM

Change 464459 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/Wikibase@master] Make Wikibase Client create wikibase_item field

https://gerrit.wikimedia.org/r/464459

gerritbot added a comment.Oct 3 2018, 11:38 PM

Change 464460 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/CirrusSearch@master] Remove wikibase_item from Cirrus codebase

https://gerrit.wikimedia.org/r/464460

Smalyshev moved this task from Next to Doing on the User-Smalyshev board.Oct 4 2018, 4:36 AM
Smalyshev added a project: Discovery-Search (Current work).
Smalyshev moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot added a comment.Oct 4 2018, 6:13 PM

Change 464458 abandoned by Smalyshev:
Expose Cirrus factory for extensions to be able to build fields.

Reason:
looks like this is not required actually

https://gerrit.wikimedia.org/r/464458

gerritbot added a comment.Oct 8 2018, 10:20 AM

Change 464459 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make Wikibase Client create wikibase_item field

https://gerrit.wikimedia.org/r/464459

gerritbot added a comment.Oct 8 2018, 10:20 AM

Change 464460 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove wikibase_item from Cirrus codebase

https://gerrit.wikimedia.org/r/464460

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 8 2018, 11:00 AM
Addshore moved this task from Investigate & Discuss to Legacy Inbox on the [DEPRECATED] wdwb-tech board.Oct 8 2018, 12:49 PM
Smalyshev moved this task from not in use - please delete to Needs Reporting on the Discovery-Search (Current work) board.Oct 9 2018, 12:39 AM
Smalyshev moved this task from Doing to Done on the User-Smalyshev board.
Smalyshev closed this task as Resolved.Oct 17 2018, 10:28 PM
Smalyshev claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL