Page MenuHomePhabricator

Fix coding standards and add phpcs checks to CI
Closed, ResolvedPublic

Description

There are a few coding convention errors in this extension. These should be fixed, and once they are, code-sniffing added to the repository's continuous-integration.

  • Add a composer.json file with a test script that runs parallel-lint and phpcs (see the BoilerPlate extension for an example).
  • Fix the style problems in the extension's files
  • Update IDS's entry in layout.yaml of the integration/config repository to include the composer-test template.

This requires two patches to be submitted via Gerrit.

Details

Related Gerrit Patches:
mediawiki/extensions/Ids : masterFollow mediawiki guidelines
mediawiki/extensions/Ids : masterIntroduce CI tests
integration/config : masterAdded Ids extension composer tests

Event Timeline

Samwilson created this task.Jan 3 2017, 1:13 AM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptJan 3 2017, 1:13 AM
Samwilson triaged this task as Medium priority.Jan 3 2017, 1:13 AM
Samwilson updated the task description. (Show Details)
Filip claimed this task.Jan 3 2017, 3:52 PM

Change 330239 had a related patch set uploaded (by Filip):
Introduce CI tests

https://gerrit.wikimedia.org/r/330239

Change 330241 had a related patch set uploaded (by Filip):
Added Ids extension composer tests

https://gerrit.wikimedia.org/r/330241

Change 330239 merged by jenkins-bot:
Introduce CI tests

https://gerrit.wikimedia.org/r/330239

Filip closed this task as Resolved.Jan 3 2017, 5:43 PM

Marking as resolved, patch merged.

Change 330241 merged by jenkins-bot:
Added Ids extension composer tests

https://gerrit.wikimedia.org/r/330241

Samwilson reopened this task as Open.Jan 3 2017, 9:46 PM

Thanks for your work so far @FilipGCI, but this task shouldn't have been closed yet as it's not complete:

FILE: .../mediawiki/extensions/Ids/ids_body.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 30 | WARNING | [x] Single space expected after opening parenthesis
 30 | WARNING | [x] Single space expected before closing parenthesis
 30 | WARNING | [x] Single space expected after opening parenthesis
 30 | WARNING | [x] Single space expected before closing parenthesis
 39 | WARNING | [x] Single space expected before closing parenthesis

Change 330422 had a related patch set uploaded (by Filip):
Follow mediawiki guidelines

https://gerrit.wikimedia.org/r/330422

Change 330422 abandoned by Umherirrender:
Follow mediawiki guidelines

Reason:
Fixes included in I872aa39b947e9ed77d4f45626641a62c84f4f391

https://gerrit.wikimedia.org/r/330422

Samwilson moved this task from Backlog to Done on the IDS-extension board.Jan 4 2017, 11:14 PM