OO.ui.infuse should not treat strings as IDs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jan 3 2017, 12:47 PM

Description

This encourages people to use IDs, when we should be encouraging class names. Strings should be handled as selectors, so if IDs are really needed you can just prefix a '#'.

Unfortunately this will be a breaking change, but better to fix this now than later.

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.35.0	mediawiki/core	master	+311 -293
	[BREAKING CHANGE] Remove deprecated infuse-by-id feature	oojs/ui	master	+26 -63

Customize query in gerrit

Related Objects

Mentioned In: T269167: Deprecate passing a selector to OO.ui.infuse

Event Timeline

Esanders created this task.Jan 3 2017, 12:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2017, 12:47 PM

It should also be possible to pass a selector that matches multiple elements, e.g. OO.ui.infuse( '.oo-ui-widget' )

Volker_E moved this task from Backlog to Next-up on the OOUI board.Feb 2 2018, 2:43 AM

Change 535890 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] [BREAKING CHANGE] Remove deprecated infuse-by-id feature

https://gerrit.wikimedia.org/r/535890

gerritbot added a project: Patch-For-Review.Sep 16 2019, 4:23 PM

Volker_E triaged this task as Medium priority.Sep 16 2019, 4:33 PM

Volker_E moved this task from Next-up to Waiting for breaking release on the OOUI board.

Change 535890 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] Remove deprecated infuse-by-id feature

https://gerrit.wikimedia.org/r/535890

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2019, 9:12 PM

Volker_E moved this task from Waiting for breaking release to OOUI-0.35.1 on the OOUI board.Oct 8 2019, 9:46 PM

Volker_E edited projects, added OOUI (OOUI-0.35.1); removed OOUI.

Change 541905 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.35.0

https://gerrit.wikimedia.org/r/541905

gerritbot added a project: Patch-For-Review.Oct 9 2019, 7:40 PM