Sprint extension broken due to renaming all ProfilePanels into ProfileMenuItems
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Rbalik
	Jan 3 2017, 5:29 PM

Description

Failed to load class or interface 'PhabricatorProfilePanelEngine': the class or interface 'PhabricatorProfilePanelEngine' is not defined in the library map for any loaded phutil library.

If you are not a developer, this almost always means that a library is out of date. For example, you may have upgraded `phabricator` without upgrading `libphutil`, or vice versa. It might also mean that you need to restart Apache or PHP-FPM. Make sure all libraries are up to date and all services have been restarted.

If you are a developer and this symbol was recently added or moved, your library map may need to be rebuilt. You can rebuild the map by running 'arc liberate'. For more information, see:

https://secure.phabricator.com/book/phabcontrib/article/adding_new_classes/

Revisions and Commits

rPHSP phabricator-Sprint
	Restricted Differential Revision	rPHSP7a7368cd2162 Make function getItemURI public
		rPHSP2bdddf418740 syncs with upstream https://secure.phabricator.

Event Timeline

Rbalik created this task.Jan 3 2017, 5:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2017, 5:29 PM

I have the same problem. I tried to restart apache, reset php opcache, and run arc liberate on phabricator's root folder, and still missing that class/interface. Phabricator and libphutil are in last git version.

Thanks for reporting this! (I adjusted the task summary to describe the problem and reset the priority to default.)

Upstream renamed all ProfilePanels into ProfileMenuItems on 2016-12-11.
Your contributed patch in Wikimedia Gerrit is welcome as the Sprint extension is not very maintained.

You're welcome. I guess it's just a simple find/replace but I doubt I'll have time to mess with this in the near future. Maybe...

@Aklapper I have the patch ready, but it seems that rights to the Sprint extension repo have been changed on Gerrit ... so I cannot even push it. Can you ask @mmodell or someone to fix this?

@Christopher would you mind posting a diff so I can get this deployed here while you guys are figuring out the repo issues?

T154499.patch3 KBDownload

@Rbalik This is a patch file for the change. Just one file is touched and it seems to fix the immediate issue ...

That fixed it. Thanks a lot

@Christopher looks like there's another spot to fix. If i'm on the burndown chart and click the name of the project above the chart, the page that loads fails with this error:

The URL pattern there is /project/sprint/profile/52

Error is:

>>> UNRECOVERABLE FATAL ERROR <<<

Undefined class constant &#039;PANEL_PROFILE&#039;

/srv/phab/libext/sprint/src/controller/SprintProjectProfileController.php:75


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

Paladox subscribed.Jan 10 2017, 8:38 PM

@Christopher Hi, the repo's are now hosted on wikipedia's own phabricator. See https://phabricator.wikimedia.org/diffusion/PHSP/

You will need to install arcanist + libphutil please.

see https://www.mediawiki.org/wiki/Phabricator/Arcanist

Also @mmodell could @Christopher be added to the group on https://phabricator.wikimedia.org/diffusion/PHSP/ to be able to land changes please?

@Christopher: You can push to rPHSP phabricator-Sprint and the changes will be replicated to gerrit automatically.

You need to have either ssh or http auth set up in phabricator:

SSH
- Set up a SSH public key
- Then add the ssh remote: ssh://vcs@git-ssh.wikimedia.org/diffusion/PHSP/phabricator-sprint.git
HTTPS
- Set a "VCS Password"
- Then add the https remote: https://phabricator.wikimedia.org/diffusion/PHSP/phabricator-sprint.git

Christopher added a commit: rPHSP2bdddf418740: syncs with upstream https://secure.phabricator..Jan 11 2017, 3:01 PM

@mmodell @Paladox

Thanks for the heads-up about Gerrit and the tip for configuration. I must have missed the notification about the Gerrit deprecation/phase-out. Anyway, pushing directly with git ssh seems to work fine for me.

Cmmata awarded a token.Jan 12 2017, 1:22 PM

Beber.else subscribed.Feb 9 2017, 12:56 PM

Hi,

I just installed release/2017-02-08/1 on Enlightenment phab and I am now getting the following error:

>>> UNRECOVERABLE FATAL ERROR <<<

Access level to SprintProjectProfilePanelEngine::getItemURI() must be public (as in class PhabricatorProfileMenuEngine)

/usr/share/php/phabricator-extensions-Sprint/src/engine/SprintProjectProfilePanelEngine.php:4


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

See https://phab.enlightenment.org/project/sprint/profile/102/

Contributed patches are welcome - I don't think Christopher has much time currently. :)

Caused by https://github.com/wikimedia/phabricator/commit/5960b1c8a3cd324d0959d8776013b2803e9ff669

Paladox added a revision: Restricted Differential Revision.Feb 9 2017, 7:23 PM

Paladox closed this task as Resolved.Feb 9 2017, 7:47 PM

Paladox assigned this task to Christopher.

Paladox removed a revision: Restricted Differential Revision.

Paladox added a commit: rPHSP7a7368cd2162: Make function getItemURI public.

	F5268880: T154499.patch
	Jan 10 2017, 7:20 PM

	Unknown Object (File)
	Jan 10 2017, 7:17 PM

Sprint extension broken due to renaming all ProfilePanels into ProfileMenuItemsClosed, ResolvedPublicActions

Description

Revisions and Commits

Event Timeline

Sprint extension broken due to renaming all ProfilePanels into ProfileMenuItems
Closed, ResolvedPublic
Actions