Page MenuHomePhabricator

Rendering of Flow history pages broken
Closed, ResolvedPublic

Description

See e.g. https://www.mediawiki.org/wiki/Talk:Download?action=history . There are lots of lines like [INVALID] edited the description . . (-13) or changed the topic title from "$5" to "[$3 $4]" . . (+6)‎.

Lots of related log errors too, they look like:

Warning: Invalid parameter for message "flow-rev-message-edit-header": a:2:{s:10:"user-links";a:1:{s:3:"raw";s:305:"<a href="/wiki/User:Kghbln" class="mw-redirect mw-userlink" title="User:Kghbln"><bdi>Kghbln</bdi></a> <span class="mw-usertoollinks">(<a href="/wiki/User_talk:Kghbln" title="User talk:Kghbln">talk</a> | <a href="/wiki/Special:Contributions/Kghbln" title="Special:Contributions/Kghbln">contribs</a>)</span>";}s:9:"user-text";s:6:"Kghbln";} in /srv/mediawiki/php-1.29.0-wmf.7/includes/Message.php on line 1172

Event Timeline

Catrope created this task.Jan 4 2017, 12:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2017, 12:34 AM
Catrope claimed this task.Jan 4 2017, 12:34 AM
Catrope triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJan 4 2017, 12:34 AM

Change 330337 had a related patch set uploaded (by Catrope):
TemplateHelper: Adjust for c67539341 in MW core

https://gerrit.wikimedia.org/r/330337

Change 330337 merged by jenkins-bot:
TemplateHelper: Adjust for c67539341 in MW core

https://gerrit.wikimedia.org/r/330337

Change 330338 had a related patch set uploaded (by Catrope):
TemplateHelper: Adjust for c67539341 in MW core

https://gerrit.wikimedia.org/r/330338

Change 330338 merged by MaxSem:
TemplateHelper: Adjust for c67539341 in MW core

https://gerrit.wikimedia.org/r/330338

greg added a subscriber: greg.Jan 4 2017, 10:50 PM

Are we good here?

Yes, checked the fix in mediawiki and testwiki.

greg closed this task as Resolved.Jan 5 2017, 6:05 PM

Resolving (just doing my UBN! task cleanup, sorry if this messes with your team's workflow...)