Page MenuHomePhabricator

Double wrapped error message for Commons tabular data
Open, NormalPublic

Description

  1. Edit a .tab page in the Data namespace. E.g. https://commons.wikimedia.org/w/index.php?title=Data:Sandbox/Krinkle/test.tab&action=edit
  2. Change value of "license" to "x".
  3. Preview or Save page

Following (expected) error is rendered:

⧼Parameter "license" must be one of the valid license codes, for example CC0-1.0+⧽

While the error is expected, there are unexpected ⧼⧽ symbols around it. This suggests that may be the error message itself is wrongly interpreted as a message key and then attempted to be retrieved again. Which falls back to rendering as ⧼key⧽ when the message is not found.

Also, this message should be styled to look like an error. E.g. using the default class="errorbox" or some such.

Event Timeline

Krinkle created this task.Jan 4 2017, 4:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2017, 4:39 AM
debt triaged this task as Normal priority.Jan 6 2017, 8:54 PM
debt added a project: Maps-Sprint.
debt added subscribers: Yurik, MaxSem.
debt added a subscriber: debt.

Moving off the sprint board - the Discovery team won't be able to finish this work at this time.

Krinkle updated the task description. (Show Details)Jun 14 2017, 5:39 PM