Page MenuHomePhabricator

Checkpoint extension uses obsolete ArticleSave hook
Closed, DeclinedPublic

Description

Extension:Checkpoint uses the ArticleSave hook, which is deprecated. The error output in MediaWiki 1.28.0 is:

PHP Deprecated:  Use of ArticleSave hook (used in efCheckpointSave) was deprecated in MediaWiki 1.21. [Called from ContentHandler::runLegacyHooks in /home/wiki/wiki/wiki/includes/content/ContentHandler.php at line 1172] in /home/wiki/wiki/wiki/includes/debug/MWDebug.php on line 311
PHP Stack trace:
PHP   1. {main}() /home/wiki/wiki/wiki/tests/phpunit/phpunit.php:0
PHP   2. require() /home/wiki/wiki/wiki/tests/phpunit/phpunit.php:163
PHP   3. PHPUnitMaintClass->execute() /home/wiki/wiki/wiki/maintenance/doMaintenance.php:111
PHP   4. PHPUnit_TextUI_Command::main() /home/wiki/wiki/wiki/tests/phpunit/phpunit.php:133
PHP   5. PHPUnit_TextUI_Command->run() /home/wiki/wiki/wiki/vendor/phpunit/phpunit/src/TextUI/Command.php:100
PHP   6. PHPUnit_TextUI_TestRunner->doRun() /home/wiki/wiki/wiki/vendor/phpunit/phpunit/src/TextUI/Command.php:149
PHP   7. PHPUnit_Framework_TestSuite->run() /home/wiki/wiki/wiki/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:440
PHP   8. PHPUnit_Framework_TestSuite->run() /home/wiki/wiki/wiki/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
PHP   9. PHPUnit_Framework_TestSuite->run() /home/wiki/wiki/wiki/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
PHP  10. PHPUnit_Framework_TestSuite->run() /home/wiki/wiki/wiki/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
PHP  11. MediaWikiTestCase->run() /home/wiki/wiki/wiki/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
PHP  12. MediaWikiTestCase->addCoreDBData() /home/wiki/wiki/wiki/tests/phpunit/MediaWikiTestCase.php:374
PHP  13. WikiPage->doEditContent() /home/wiki/wiki/wiki/tests/phpunit/MediaWikiTestCase.php:1030
PHP  14. ContentHandler::runLegacyHooks() /home/wiki/wiki/wiki/includes/page/WikiPage.php:1686
PHP  15. Hooks::run() /home/wiki/wiki/wiki/includes/content/ContentHandler.php:1172
PHP  16. wfDeprecated() /home/wiki/wiki/wiki/includes/Hooks.php:192
PHP  17. MWDebug::deprecated() /home/wiki/wiki/wiki/includes/GlobalFunctions.php:1128
PHP  18. MWDebug::sendMessage() /home/wiki/wiki/wiki/includes/debug/MWDebug.php:243
PHP  19. trigger_error() /home/wiki/wiki/wiki/includes/debug/MWDebug.php:311

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2017, 9:15 PM

Looks like someone already patched this for bug T151973:

https://gerrit.wikimedia.org/r/#/c/327771/

This can be closed.

maiden_taiwan closed this task as Declined.Jan 4 2017, 9:19 PM