Page MenuHomePhabricator
Create Task
Maniphest T154626

[regression pre-wmf.7] Using VE Help shortcut displays multiple windows after invoking the popup in Flow board description
Closed, ResolvedPublic
Actions

Description

Specific to Flow posts replies/edits.

  1. On a Flow board, click on any 'Reply' or 'Edit' options, or click in the Reply text box.
  2. Use VEHelp shortcut (the edit mode should be VE) - cmd+?
  3. The VE Help will open - click on 'Done', the popup closes without problems.
  1. Now, repeat the steps above when editing Flow board description - the first time the popup invoked, it closes without any problems.
  2. After that, open Reply, Edit reply, or Edit summary and use 'cmd+?' to invoke VE Help shortcut popup.
  3. Click on 'Done' and multiple popups will be present.

Simpler way to reproduce

  • Open two replies on a Flow board
  • Click outside of the flow board
  • Press ctrl+?

The screen recording is attached

multiple_VEHelp_windows.mov3 MBDownload

Details

SubjectRepoBranchLines +/-
ArticleTarget: Restore 'commandHelp' to documentCommandsmediawiki/extensions/VisualEditormaster+2 -0
Update VE core submodule to master (2cbef5626)mediawiki/extensions/VisualEditormaster+1 -1
Help dialog: Don't register as a documentCommand by defaultVisualEditor/VisualEditormaster+2 -2
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Jan 4 2017, 11:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2017, 11:20 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017); removed Collaboration-Team-Triage.Jan 25 2017, 2:57 AM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.
Jdforrester-WMF moved this task from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Mar 18 2017, 1:26 AM
Jdforrester-WMF added a project: StructuredDiscussions.
Jdforrester-WMF subscribed.

I can't reproduce in quick testing on Beta Cluster – fixed?

Etonkovidova closed this task as Resolved.Mar 19 2017, 6:25 PM
Etonkovidova triaged this task as Low priority.
Etonkovidova updated the task description. (Show Details)
Etonkovidova renamed this task from [regression pre-wmf.7] Using VE Help shortcut displays multiple windows to [regression pre-wmf.7] Using VE Help shortcut displays multiple windows after invoking the popup in Flow board description.Mar 19 2017, 7:24 PM
Etonkovidova reopened this task as Open.
Etonkovidova lowered the priority of this task from Low to Lowest.
Etonkovidova updated the task description. (Show Details)
Etonkovidova moved this task from QA Review to Untriaged on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Mar 19 2017, 7:29 PM
Etonkovidova added a comment.Apr 11 2017, 6:04 PM

I closed the bug - and I was wrong. The issue is reproducible in production (wmf.16) and in betalabs.

It turned out that it's little bit trickier to reproduce and I corrected the steps in the ticket.

After some testing, it seems that multiple popups of VE shortcut are triggered by invoking the VE shortcut popup when editing Flow board description. After that, multiple popups will appear every time when 'cmd+?' is pressed in Reply, Summary, and Edit reply. I've corrected the description.

• jmatazzoni edited projects, added Collaboration-Team-Triage; removed Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017).Apr 12 2017, 6:09 PM
• jmatazzoni moved this task from Untriaged to Flow Holding Area on the Collaboration-Team-Triage board.
Aklapper removed a project: Collaboration-Team-Triage.Oct 12 2019, 4:11 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 12 2019, 4:11 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:00 PM
Esanders updated the task description. (Show Details)Jun 15 2022, 11:59 AM
gerritbot added a comment.Jun 15 2022, 12:05 PM

Change 805792 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Help dialog: Don't register as a documentCommand by default

https://gerrit.wikimedia.org/r/805792

gerritbot added a project: Patch-For-Review.Jun 15 2022, 12:05 PM
gerritbot added a comment.Jun 15 2022, 12:15 PM

Change 805796 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] ArticleTarget: Restore 'commandHelp' to documentCommands

https://gerrit.wikimedia.org/r/805796

gerritbot added a comment.Jun 15 2022, 10:39 PM

Change 805792 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Help dialog: Don't register as a documentCommand by default

https://gerrit.wikimedia.org/r/805792

gerritbot added a comment.Jun 15 2022, 10:45 PM

Change 805916 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2cbef5626)

https://gerrit.wikimedia.org/r/805916

gerritbot added a comment.Jun 15 2022, 11:01 PM

Change 805916 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2cbef5626)

https://gerrit.wikimedia.org/r/805916

gerritbot added a comment.Jun 15 2022, 11:01 PM

Change 805796 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ArticleTarget: Restore 'commandHelp' to documentCommands

https://gerrit.wikimedia.org/r/805796

matmarex closed this task as Resolved.Jun 15 2022, 11:19 PM
matmarex assigned this task to Esanders.
matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 16 2022, 12:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits