Page MenuHomePhabricator

Design of diffs should be improved to indicate white space changes better
Open, NormalPublic

Description

When two lines only differ in white spaces, this difference is not hilighted good enough. One would expect the white space(s) to be rendered with a (say) red background on the side where it exists (or, maybe, on the side it is omitted).


Version: unspecified
Severity: enhancement

Details

Reference
bz13466

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz13466.
bzimport added a subscriber: Unknown Object (MLST).
Huji created this task.Mar 21 2008, 8:49 AM

Should be better after r32282.

  • Bug 286 has been marked as a duplicate of this bug. ***
  • Bug 1208 has been marked as a duplicate of this bug. ***

Yeah it doesn't look so nice with long changes inside one line, because it adds the border unlike for totally new or removed lines. Have to find suitable compromise between highlighting short whitespace changes and not overhighlighting long changes.

ayg wrote:

Aaron reverted this in r33580.

ayg wrote:

Maybe a different background color would be more attractive than a dotted border?

The whitespace still needs to be mungled to prevent collapsing it.

sumanah wrote:

green highlighted line on right should show added spaces at end, does not

Not sure whether http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28proposals%29&curid=3706897&diff=206582971&oldid=206580490 still shows the problem Aaron was pointing to. However, https://en.wikipedia.org/w/index.php?title=User%3ASumanah&action=historysubmit&diff=454459831&oldid=454452518 does (I believe) demonstrate the problem; screenshot attached.

Attached:

sumanah wrote:

Still an issue in 1.18.

Added "design" keyword - would appreciate some design thinking on how to, as Niklas summarizes in comment 5, "find suitable compromise between highlighting short whitespace changes and not overhighlighting long changes."

  • Bug 3894 has been marked as a duplicate of this bug. ***

Moving under wikidiff2 per bug 13462 comment 7, although Nikerabbit says «dwdiff can use delimeters, that's not quite character level diff, [...] the algorithms are probably very different».

I suppose that this blocks bug 745, the tracker for RTL bugs, because it also doesn't clearly display changes in characters like RLM/LRM. Whoever resolves this should also consider showing emphasizing these characters somehow.

Jorm removed a subscriber: Jorm.Mar 2 2015, 9:20 PM

I don't know what the merged task talked about, but this bug is about *identification* of whitespace changes, not about their display. Display was already fixed, see https://www.mediawiki.org/wiki/MediaWiki_1.20#Diff

Restricted Application added a project: I18n. · View Herald TranscriptJun 2 2015, 2:20 PM
Ebraminio moved this task from Backlog to MediaWiki-core on the RTL board.Aug 9 2015, 11:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2015, 11:47 AM
Meno25 removed a subscriber: Meno25.Feb 22 2016, 6:11 PM
Jay8g added a subscriber: Jay8g.Apr 9 2016, 6:42 AM
Nemo_bis rescinded a token.Jul 16 2016, 8:00 AM
Nemo_bis awarded a token.
Amire80 moved this task from Untriaged to RTL on the I18n board.Feb 28 2018, 12:12 PM