Page MenuHomePhabricator

No longer existing method is used in installer.
Closed, ResolvedPublic

Description

Recently, installing MediaWiki 1.28.0 i encountered a problem. It's cause seems to be part of canCreateAccounts method located at line 314 of /includes/installer/MysqlInstaller.php file. It looks like on some servers this code is executed and it's causing error. Here's full error:

Notice: Undefined property: stdClass::$PRIVILEGE_TYPE in /public_html/w/includes/installer/MysqlInstaller.php on line 283

Notice: Undefined property: stdClass::$IS_GRANTABLE in /public_html/w/includes/installer/MysqlInstaller.php on line 286

Fatal error: Call to undefined method DatabaseMysqli::likeToRegex() in /public_html/w/includes/installer/MysqlInstaller.php on line 315

Event Timeline

MaciekP42 created this task.Jan 5 2017, 4:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2017, 4:00 PM

The method seems to have never existed on master. But I found it in the new-installer branch from 2010: rSVN45497. It seems to have been removed before that was merged (rMWa4393915 / rSVN66008).

matmarex claimed this task.Jan 11 2017, 1:01 AM
matmarex triaged this task as Normal priority.

Change 331647 had a related patch set uploaded (by Bartosz Dziewoński):
MysqlInstaller: Restore missing function

https://gerrit.wikimedia.org/r/331647

Change 331648 had a related patch set uploaded (by Bartosz Dziewoński):
MysqlInstaller: Restore missing function

https://gerrit.wikimedia.org/r/331648

Change 331647 merged by jenkins-bot:
MysqlInstaller: Restore missing function

https://gerrit.wikimedia.org/r/331647

Change 331648 merged by jenkins-bot:
MysqlInstaller: Restore missing function

https://gerrit.wikimedia.org/r/331648

matmarex closed this task as Resolved.Jan 11 2017, 9:32 PM
matmarex removed a project: Patch-For-Review.