No longer existing method is used in installer.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MaciekP42
	Jan 5 2017, 4:00 PM

Description

Recently, installing MediaWiki 1.28.0 i encountered a problem. It's cause seems to be part of canCreateAccounts method located at line 314 of /includes/installer/MysqlInstaller.php file. It looks like on some servers this code is executed and it's causing error. Here's full error:

Notice: Undefined property: stdClass::$PRIVILEGE_TYPE in /public_html/w/includes/installer/MysqlInstaller.php on line 283

Notice: Undefined property: stdClass::$IS_GRANTABLE in /public_html/w/includes/installer/MysqlInstaller.php on line 286

Fatal error: Call to undefined method DatabaseMysqli::likeToRegex() in /public_html/w/includes/installer/MysqlInstaller.php on line 315

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	MysqlInstaller: Restore missing function	mediawiki/core	REL1_28	+16 -1
	MysqlInstaller: Restore missing function	mediawiki/core	master	+14 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMWa4393915e2bc: Merge new-installer branch to trunk * This is not complete yet, and should not…
rSVN45497: * Made it possible to set $wgLogo to false and have no logo. Made this the…
rSVN66008: Merge new-installer branch to trunk

Event Timeline

MaciekP42 created this task.Jan 5 2017, 4:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2017, 4:00 PM

The method seems to have never existed on master. But I found it in the new-installer branch from 2010: rSVN45497. It seems to have been removed before that was merged (rMWa4393915 / rSVN66008).

Paladox subscribed.Jan 5 2017, 11:10 PM

matmarex claimed this task.Jan 11 2017, 1:01 AM

matmarex triaged this task as Medium priority.

Change 331647 had a related patch set uploaded (by Bartosz Dziewoński):
MysqlInstaller: Restore missing function

https://gerrit.wikimedia.org/r/331647

gerritbot added a project: Patch-For-Review.Jan 11 2017, 6:23 PM

matmarex added a project: MW-1.28-release.Jan 11 2017, 6:25 PM

Change 331648 had a related patch set uploaded (by Bartosz Dziewoński):
MysqlInstaller: Restore missing function

https://gerrit.wikimedia.org/r/331648

Change 331647 merged by jenkins-bot:
MysqlInstaller: Restore missing function

https://gerrit.wikimedia.org/r/331647

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 11 2017, 8:00 PM